2017-12-19 19:55:06

by Laura Abbott

Subject: [PATCH] tools/power: Don't make man pages executable

rpm-lint flagged these as being executable:

kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/turbostat.8.gz
kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/x86_energy_perf_policy.8.gz

Fix this

Signed-off-by: Laura Abbott <[email protected]>
---
tools/power/x86/turbostat/Makefile | 2 +-
tools/power/x86/x86_energy_perf_policy/Makefile | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/power/x86/turbostat/Makefile b/tools/power/x86/turbostat/Makefile
index a9bc914a8fe8..2ab25aa38263 100644
--- a/tools/power/x86/turbostat/Makefile
+++ b/tools/power/x86/turbostat/Makefile
@@ -25,4 +25,4 @@ install : turbostat
install -d $(DESTDIR)$(PREFIX)/bin
install $(BUILD_OUTPUT)/turbostat $(DESTDIR)$(PREFIX)/bin/turbostat
install -d $(DESTDIR)$(PREFIX)/share/man/man8
- install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
+ install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
diff --git a/tools/power/x86/x86_energy_perf_policy/Makefile b/tools/power/x86/x86_energy_perf_policy/Makefile
index 2447b1bbaacf..f4534fb8b951 100644
--- a/tools/power/x86/x86_energy_perf_policy/Makefile
+++ b/tools/power/x86/x86_energy_perf_policy/Makefile
@@ -24,5 +24,5 @@ install : x86_energy_perf_policy
install -d $(DESTDIR)$(PREFIX)/bin
install $(BUILD_OUTPUT)/x86_energy_perf_policy $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy
install -d $(DESTDIR)$(PREFIX)/share/man/man8
- install x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
+ install -m 644 x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8

--
2.14.3

2017-12-19 23:48:15

by Wysocki, Rafael J

Subject: Re: [PATCH] tools/power: Don't make man pages executable

On 12/19/2017 8:54 PM, Laura Abbott wrote:
> rpm-lint flagged these as being executable:
>
> kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/turbostat.8.gz
> kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/x86_energy_perf_policy.8.gz
>
> Fix this
>
> Signed-off-by: Laura Abbott <[email protected]>

Please CC PM stuff to linux-pm (which makes it easier to handle).

> ---
> tools/power/x86/turbostat/Makefile | 2 +-
> tools/power/x86/x86_energy_perf_policy/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/power/x86/turbostat/Makefile b/tools/power/x86/turbostat/Makefile
> index a9bc914a8fe8..2ab25aa38263 100644
> --- a/tools/power/x86/turbostat/Makefile
> +++ b/tools/power/x86/turbostat/Makefile
> @@ -25,4 +25,4 @@ install : turbostat
> install -d $(DESTDIR)$(PREFIX)/bin
> install $(BUILD_OUTPUT)/turbostat $(DESTDIR)$(PREFIX)/bin/turbostat
> install -d $(DESTDIR)$(PREFIX)/share/man/man8
> - install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
> + install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
> diff --git a/tools/power/x86/x86_energy_perf_policy/Makefile b/tools/power/x86/x86_energy_perf_policy/Makefile
> index 2447b1bbaacf..f4534fb8b951 100644
> --- a/tools/power/x86/x86_energy_perf_policy/Makefile
> +++ b/tools/power/x86/x86_energy_perf_policy/Makefile
> @@ -24,5 +24,5 @@ install : x86_energy_perf_policy
> install -d $(DESTDIR)$(PREFIX)/bin
> install $(BUILD_OUTPUT)/x86_energy_perf_policy $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy
> install -d $(DESTDIR)$(PREFIX)/share/man/man8
> - install x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
> + install -m 644 x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
>


Thanks,

Rafael

2017-12-20 00:36:34

by Laura Abbott

Subject: Re: [PATCH] tools/power: Don't make man pages executable

On 12/19/2017 03:48 PM, Rafael J. Wysocki wrote:
> On 12/19/2017 8:54 PM, Laura Abbott wrote:
>> rpm-lint flagged these as being executable:
>>
>> kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/turbostat.8.gz
>> kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/x86_energy_perf_policy.8.gz
>>
>> Fix this
>>
>> Signed-off-by: Laura Abbott <[email protected]>
>
> Please CC PM stuff to linux-pm (which makes it easier to handle).
>

Neither of these are listed in MAINTAINERS so I missed sending to
linux-pm. I'll remember for next time, do you want me to resend
for tracking?

Thanks,
Laura

>> ---
>>   tools/power/x86/turbostat/Makefile              | 2 +-
>>   tools/power/x86/x86_energy_perf_policy/Makefile | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/power/x86/turbostat/Makefile b/tools/power/x86/turbostat/Makefile
>> index a9bc914a8fe8..2ab25aa38263 100644
>> --- a/tools/power/x86/turbostat/Makefile
>> +++ b/tools/power/x86/turbostat/Makefile
>> @@ -25,4 +25,4 @@ install : turbostat
>>       install -d  $(DESTDIR)$(PREFIX)/bin
>>       install $(BUILD_OUTPUT)/turbostat $(DESTDIR)$(PREFIX)/bin/turbostat
>>       install -d  $(DESTDIR)$(PREFIX)/share/man/man8
>> -    install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
>> +    install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
>> diff --git a/tools/power/x86/x86_energy_perf_policy/Makefile b/tools/power/x86/x86_energy_perf_policy/Makefile
>> index 2447b1bbaacf..f4534fb8b951 100644
>> --- a/tools/power/x86/x86_energy_perf_policy/Makefile
>> +++ b/tools/power/x86/x86_energy_perf_policy/Makefile
>> @@ -24,5 +24,5 @@ install : x86_energy_perf_policy
>>       install -d  $(DESTDIR)$(PREFIX)/bin
>>       install $(BUILD_OUTPUT)/x86_energy_perf_policy $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy
>>       install -d  $(DESTDIR)$(PREFIX)/share/man/man8
>> -    install x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
>> +    install -m 644 x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
>
>
> Thanks,
>
> Rafael
>
>

2017-12-20 01:36:07

by Wysocki, Rafael J

Subject: Re: [PATCH] tools/power: Don't make man pages executable

On 12/20/2017 1:36 AM, Laura Abbott wrote:
> On 12/19/2017 03:48 PM, Rafael J. Wysocki wrote:
>> On 12/19/2017 8:54 PM, Laura Abbott wrote:
>>> rpm-lint flagged these as being executable:
>>>
>>> kernel-tools.x86_64: W: spurious-executable-perm
>>> /usr/share/man/man8/turbostat.8.gz
>>> kernel-tools.x86_64: W: spurious-executable-perm
>>> /usr/share/man/man8/x86_energy_perf_policy.8.gz
>>>
>>> Fix this
>>>
>>> Signed-off-by: Laura Abbott <[email protected]>
>>
>> Please CC PM stuff to linux-pm (which makes it easier to handle).
>>
>
> Neither of these are listed in MAINTAINERS so I missed sending to
> linux-pm. I'll remember for next time, do you want me to resend
> for tracking?
>

Yes, please.

Thanks,
Rafael


>
>>> ---
>>>   tools/power/x86/turbostat/Makefile              | 2 +-
>>>   tools/power/x86/x86_energy_perf_policy/Makefile | 2 +-
>>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tools/power/x86/turbostat/Makefile
>>> b/tools/power/x86/turbostat/Makefile
>>> index a9bc914a8fe8..2ab25aa38263 100644
>>> --- a/tools/power/x86/turbostat/Makefile
>>> +++ b/tools/power/x86/turbostat/Makefile
>>> @@ -25,4 +25,4 @@ install : turbostat
>>>       install -d  $(DESTDIR)$(PREFIX)/bin
>>>       install $(BUILD_OUTPUT)/turbostat
>>> $(DESTDIR)$(PREFIX)/bin/turbostat
>>>       install -d  $(DESTDIR)$(PREFIX)/share/man/man8
>>> -    install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
>>> +    install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
>>> diff --git a/tools/power/x86/x86_energy_perf_policy/Makefile
>>> b/tools/power/x86/x86_energy_perf_policy/Makefile
>>> index 2447b1bbaacf..f4534fb8b951 100644
>>> --- a/tools/power/x86/x86_energy_perf_policy/Makefile
>>> +++ b/tools/power/x86/x86_energy_perf_policy/Makefile
>>> @@ -24,5 +24,5 @@ install : x86_energy_perf_policy
>>>       install -d  $(DESTDIR)$(PREFIX)/bin
>>>       install $(BUILD_OUTPUT)/x86_energy_perf_policy
>>> $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy
>>>       install -d  $(DESTDIR)$(PREFIX)/share/man/man8
>>> -    install x86_energy_perf_policy.8
>>> $(DESTDIR)$(PREFIX)/share/man/man8
>>> +    install -m 644 x86_energy_perf_policy.8
>>> $(DESTDIR)$(PREFIX)/share/man/man8
>>
>>
>> Thanks,
>>
>> Rafael
>>
>>
>