2018-01-03 05:13:49

by Arvind Yadav

Subject: [PATCH] ata_piix: constify pci_bits

pci_bits are not supposed to change at runtime. Functions
pci_test_config_bits() working with const 'struct pci_bits'.
So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/ata/ata_piix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index b702c20..7ecb132 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -458,7 +458,7 @@ struct piix_host_priv {
[ich8_2port_sata_byt] = &ich8_2port_map_db,
};

-static struct pci_bits piix_enable_bits[] = {
+static const struct pci_bits piix_enable_bits[] = {
{ 0x41U, 1U, 0x80UL, 0x80UL }, /* port 0 */
{ 0x43U, 1U, 0x80UL, 0x80UL }, /* port 1 */
};
--
1.9.1

2018-01-08 14:16:15

by Tejun Heo

Subject: Re: [PATCH] ata_piix: constify pci_bits

On Wed, Jan 03, 2018 at 10:43:34AM +0530, Arvind Yadav wrote:
> pci_bits are not supposed to change at runtime. Functions
> pci_test_config_bits() working with const 'struct pci_bits'.
> So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Applied to libata/for-4.16.

Thanks.

--
tejun