2018-05-28 13:48:40

by Luc Van Oostenryck

[permalink] [raw]
Subject: [PATCH] kbuild: $(CHECK) doesnt need NOSTDINC_FLAGS twice

Currently, $(CHECK) receives NOSTDINC_FLAGS twice:
* first directly in the main Makefile via CHECKFLAGS,
* then indirectly in scripts/Makefile.build via c_flags.

Since once is enough, leave the occurence via c_flags and
remove the one via CHECKFLAGS.

Signed-off-by: Luc Van Oostenryck <[email protected]>
---
Makefile | 1 -
1 file changed, 1 deletion(-)

diff --git a/Makefile b/Makefile
index 56ba070df..3140ab1db 100644
--- a/Makefile
+++ b/Makefile
@@ -808,7 +808,6 @@ endif

# arch Makefile may override CC so keep this after arch Makefile is included
NOSTDINC_FLAGS += -nostdinc -isystem $(call shell-cached,$(CC) -print-file-name=include)
-CHECKFLAGS += $(NOSTDINC_FLAGS)

# warn about C99 declaration after statement
KBUILD_CFLAGS += $(call cc-option,-Wdeclaration-after-statement,)
--
2.17.0



2018-05-29 13:09:46

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH] kbuild: $(CHECK) doesnt need NOSTDINC_FLAGS twice

2018-05-28 22:47 GMT+09:00 Luc Van Oostenryck <[email protected]>:
> Currently, $(CHECK) receives NOSTDINC_FLAGS twice:
> * first directly in the main Makefile via CHECKFLAGS,
> * then indirectly in scripts/Makefile.build via c_flags.
>
> Since once is enough, leave the occurence via c_flags and
> remove the one via CHECKFLAGS.
>
> Signed-off-by: Luc Van Oostenryck <[email protected]>
> ---

Applied to linux-kbuild. Thanks.


> Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 56ba070df..3140ab1db 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -808,7 +808,6 @@ endif
>
> # arch Makefile may override CC so keep this after arch Makefile is included
> NOSTDINC_FLAGS += -nostdinc -isystem $(call shell-cached,$(CC) -print-file-name=include)
> -CHECKFLAGS += $(NOSTDINC_FLAGS)
>
> # warn about C99 declaration after statement
> KBUILD_CFLAGS += $(call cc-option,-Wdeclaration-after-statement,)
> --
> 2.17.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
Best Regards
Masahiro Yamada