2018-07-06 13:06:50

by Benjamin Gaignard

Subject: [PATCH] media: stm32: dcmi: replace "%p" with "%pK"

The format specifier "%p" can leak kernel addresses.
Use "%pK" instead.

Signed-off-by: Benjamin Gaignard <[email protected]>
---
drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
index 2e1933d872ee..fe90672cf16f 100644
--- a/drivers/media/platform/stm32/stm32-dcmi.c
+++ b/drivers/media/platform/stm32/stm32-dcmi.c
@@ -1753,7 +1753,7 @@ static int dcmi_probe(struct platform_device *pdev)

ret = clk_prepare(mclk);
if (ret) {
- dev_err(&pdev->dev, "Unable to prepare mclk %p\n", mclk);
+ dev_err(&pdev->dev, "Unable to prepare mclk %pK\n", mclk);
goto err_dma_release;
}

--
2.15.0

2018-07-06 13:53:40

by Hans Verkuil

Subject: Re: [PATCH] media: stm32: dcmi: replace "%p" with "%pK"

On 06/07/18 15:03, Benjamin Gaignard wrote:
> The format specifier "%p" can leak kernel addresses.
> Use "%pK" instead.

This patch no longer applies. AFAICT it is obsolete after some code reorg.

Regards,

Hans

>
> Signed-off-by: Benjamin Gaignard <[email protected]>
> ---
> drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
> index 2e1933d872ee..fe90672cf16f 100644
> --- a/drivers/media/platform/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/stm32/stm32-dcmi.c
> @@ -1753,7 +1753,7 @@ static int dcmi_probe(struct platform_device *pdev)
>
> ret = clk_prepare(mclk);
> if (ret) {
> - dev_err(&pdev->dev, "Unable to prepare mclk %p\n", mclk);
> + dev_err(&pdev->dev, "Unable to prepare mclk %pK\n", mclk);
> goto err_dma_release;
> }
>
>