2018-07-26 22:28:33

by Anders Roxell

[permalink] [raw]
Subject: [PATCH] clk: mvebu: armada-37xx-periph: Remove unused var num_parents

When building armada-37xx-periph, num_parents isn't used in function
clk_pm_cpu_get_parent:
drivers/clk/mvebu/armada-37xx-periph.c: In function ‘clk_pm_cpu_get_parent’:
drivers/clk/mvebu/armada-37xx-periph.c:419:6: warning: unused variable ‘num_parents’ [-Wunused-variable]
int num_parents = clk_hw_get_num_parents(hw);
^~~~~~~~~~~
Remove the declaration of num_parents to dispose the warning.

Fixes: 616bf80d381d ("clk: mvebu: armada-37xx-periph: Fix wrong return value in get_parent")
Signed-off-by: Anders Roxell <[email protected]>
---
drivers/clk/mvebu/armada-37xx-periph.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mvebu/armada-37xx-periph.c
index 287e98a7cff4..499f5962c8b0 100644
--- a/drivers/clk/mvebu/armada-37xx-periph.c
+++ b/drivers/clk/mvebu/armada-37xx-periph.c
@@ -416,7 +416,6 @@ static unsigned int armada_3700_pm_dvfs_get_cpu_parent(struct regmap *base)
static u8 clk_pm_cpu_get_parent(struct clk_hw *hw)
{
struct clk_pm_cpu *pm_cpu = to_clk_pm_cpu(hw);
- int num_parents = clk_hw_get_num_parents(hw);
u32 val;

if (armada_3700_pm_dvfs_is_enabled(pm_cpu->nb_pm_base)) {
--
2.18.0



2018-07-27 16:57:47

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] clk: mvebu: armada-37xx-periph: Remove unused var num_parents

Quoting Anders Roxell (2018-07-26 15:27:21)
> When building armada-37xx-periph, num_parents isn't used in function
> clk_pm_cpu_get_parent:
> drivers/clk/mvebu/armada-37xx-periph.c: In function ‘clk_pm_cpu_get_parent’:
> drivers/clk/mvebu/armada-37xx-periph.c:419:6: warning: unused variable ‘num_parents’ [-Wunused-variable]
> int num_parents = clk_hw_get_num_parents(hw);
> ^~~~~~~~~~~
> Remove the declaration of num_parents to dispose the warning.
>
> Fixes: 616bf80d381d ("clk: mvebu: armada-37xx-periph: Fix wrong return value in get_parent")
> Signed-off-by: Anders Roxell <[email protected]>
> ---

Applied to clk-next