2018-07-27 06:16:58

by Yi Wang

Subject: [PATCH] x86/apic: fix two slight indenting

There are two inconsistent indenting in calibrate_APIC_clock()
and activate_managed(). Remove the surplus TAB.

Signed-off-by: Yi Wang <[email protected]>
Reviewed-by: Jiang Biao <[email protected]>
---
arch/x86/kernel/apic/apic.c | 2 +-
arch/x86/kernel/apic/vector.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 5071cc7..f222ebc 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -937,7 +937,7 @@ static int __init calibrate_APIC_clock(void)

if (levt->features & CLOCK_EVT_FEAT_DUMMY) {
pr_warning("APIC timer disabled due to verification failure\n");
- return -1;
+ return -1;
}

return 0;
diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
index b708f59..19e0b2f 100644
--- a/arch/x86/kernel/apic/vector.c
+++ b/arch/x86/kernel/apic/vector.c
@@ -433,7 +433,7 @@ static int activate_managed(struct irq_data *irqd)
pr_err("Managed startup irq %u, no vector available\n",
irqd->irq);
}
- return ret;
+ return ret;
}

static int x86_vector_activate(struct irq_domain *dom, struct irq_data *irqd,
--
1.8.3.1

2018-07-27 15:34:55

by Steven Rostedt

Subject: Re: [PATCH] x86/apic: fix two slight indenting

This looks like it should go through the trivial tree. Although I'm not
the maintainer of this code, it looks reasonable to me, and I'll give
my:

Acked-by: Steven Rostedt (VMware) <[email protected]>

-- Steve


On Fri, 27 Jul 2018 14:15:03 +0800
Yi Wang <[email protected]> wrote:

> There are two inconsistent indenting in calibrate_APIC_clock()
> and activate_managed(). Remove the surplus TAB.
>
> Signed-off-by: Yi Wang <[email protected]>
> Reviewed-by: Jiang Biao <[email protected]>
> ---
> arch/x86/kernel/apic/apic.c | 2 +-
> arch/x86/kernel/apic/vector.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index 5071cc7..f222ebc 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -937,7 +937,7 @@ static int __init calibrate_APIC_clock(void)
>
> if (levt->features & CLOCK_EVT_FEAT_DUMMY) {
> pr_warning("APIC timer disabled due to verification failure\n");
> - return -1;
> + return -1;
> }
>
> return 0;
> diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
> index b708f59..19e0b2f 100644
> --- a/arch/x86/kernel/apic/vector.c
> +++ b/arch/x86/kernel/apic/vector.c
> @@ -433,7 +433,7 @@ static int activate_managed(struct irq_data *irqd)
> pr_err("Managed startup irq %u, no vector available\n",
> irqd->irq);
> }
> - return ret;
> + return ret;
> }
>
> static int x86_vector_activate(struct irq_domain *dom, struct irq_data *irqd,

2018-07-30 06:18:59

by Yi Wang

Subject: Re: [PATCH] x86/apic: fix two slight indenting

Thanks a lot, Steven.










---

Best wishes

Yi Wang






Original Mail



Sender: StevenRostedt <[email protected]>
To: Wang Yi10129963;
CC: [email protected] <[email protected]>[email protected] <[email protected]>[email protected] <[email protected]>[email protected] <[email protected]>[email protected] <[email protected]>[email protected] <[email protected]>[email protected] <[email protected]>[email protected] <[email protected]>[email protected] <[email protected]>[email protected] <[email protected]>Jiang Biao10062664;Zhong Weidong10001088;[email protected] <[email protected]>
Date: 2018/07/27 23:33
Subject: Re: [PATCH] x86/apic: fix two slight indenting



This looks like it should go through the trivial tree. Although I'm not
the maintainer of this code, it looks reasonable to me, and I'll give
my:

Acked-by: Steven Rostedt (VMware) <[email protected]>

-- Steve


On Fri, 27 Jul 2018 14:15:03 +0800
Yi Wang <[email protected]> wrote:

> There are two inconsistent indenting in calibrate_APIC_clock()
> and activate_managed(). Remove the surplus TAB.
>
> Signed-off-by: Yi Wang <[email protected]>
> Reviewed-by: Jiang Biao <[email protected]>
> ---
> arch/x86/kernel/apic/apic.c | 2 +-
> arch/x86/kernel/apic/vector.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index 5071cc7..f222ebc 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -937,7 +937,7 @@ static int __init calibrate_APIC_clock(void)
>
> if (levt->features & CLOCK_EVT_FEAT_DUMMY) {
> pr_warning("APIC timer disabled due to verification failure\n");
> - return -1;
> + return -1;
> }
>
> return 0;
> diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
> index b708f59..19e0b2f 100644
> --- a/arch/x86/kernel/apic/vector.c
> +++ b/arch/x86/kernel/apic/vector.c
> @@ -433,7 +433,7 @@ static int activate_managed(struct irq_data *irqd)
> pr_err("Managed startup irq %u, no vector available\n",
> irqd->irq);
> }
> - return ret;
> + return ret;
> }
>
> static int x86_vector_activate(struct irq_domain *dom, struct irq_data *irqd,

2018-07-30 18:02:18

by tip-bot for Vasyl Gomonovych

Subject: [tip:x86/apic] x86/apic: Trivial coding style fixes

Commit-ID: 843c408905010fbc44a564d2de6a3cd68d986abf
Gitweb: https://git.kernel.org/tip/843c408905010fbc44a564d2de6a3cd68d986abf
Author: Yi Wang <[email protected]>
AuthorDate: Fri, 27 Jul 2018 14:15:03 +0800
Committer: Thomas Gleixner <[email protected]>
CommitDate: Mon, 30 Jul 2018 19:56:30 +0200

x86/apic: Trivial coding style fixes

There is inconsistent indenting in calibrate_APIC_clock() and
activate_managed(). Remove the surplus TAB.

Signed-off-by: Yi Wang <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Reviewed-by: Jiang Biao <[email protected]>
Acked-by: Steven Rostedt (VMware) <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Link: https://lkml.kernel.org/r/[email protected]

---
arch/x86/kernel/apic/apic.c | 2 +-
arch/x86/kernel/apic/vector.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 2aabd4cb0e3f..00011bc33263 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -937,7 +937,7 @@ static int __init calibrate_APIC_clock(void)

if (levt->features & CLOCK_EVT_FEAT_DUMMY) {
pr_warning("APIC timer disabled due to verification failure\n");
- return -1;
+ return -1;
}

return 0;
diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
index a75de0792942..c943499375c3 100644
--- a/arch/x86/kernel/apic/vector.c
+++ b/arch/x86/kernel/apic/vector.c
@@ -415,7 +415,7 @@ static int activate_managed(struct irq_data *irqd)
pr_err("Managed startup irq %u, no vector available\n",
irqd->irq);
}
- return ret;
+ return ret;
}

static int x86_vector_activate(struct irq_domain *dom, struct irq_data *irqd,