From: Colin Ian King <[email protected]>
Pointer STbuffer is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'STbuffer' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/scsi/st.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 50c66ccc4b41..307df2fa39a3 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -828,11 +828,8 @@ static int st_flush_write_buffer(struct scsi_tape * STp)
static int flush_buffer(struct scsi_tape *STp, int seek_next)
{
int backspace, result;
- struct st_buffer *STbuffer;
struct st_partstat *STps;
- STbuffer = STp->buffer;
-
/*
* If there was a bus reset, block further access
* to this device.
--
2.17.1
> On 3 Aug 2018, at 13.47, Colin King <[email protected]> wrote:
>
> From: Colin Ian King <[email protected]>
>
> Pointer STbuffer is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'STbuffer' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <[email protected]>
Acked-by: Kai Mäkisara <[email protected]>
Has been unused at least since 2005 :-)
Thanks,
Kai
Colin,
> Pointer STbuffer is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'STbuffer' set but not used [-Wunused-but-set-variable]
Applied to 4.19/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering