2018-09-26 09:25:49

by Michal Hocko

[permalink] [raw]
Subject: Re: [PATCH 03/30] mm: remove CONFIG_HAVE_MEMBLOCK

On Fri 14-09-18 15:10:18, Mike Rapoport wrote:
> All architecures use memblock for early memory management. There is no need
> for the CONFIG_HAVE_MEMBLOCK configuration option.

git grep says
arch/csky/Kconfig: select HAVE_MEMBLOCK

> Signed-off-by: Mike Rapoport <[email protected]>

Other than that
Acked-by: Michal Hocko <[email protected]>
--
Michal Hocko
SUSE Labs


2018-09-26 11:56:12

by Mike Rapoport

[permalink] [raw]
Subject: Re: [PATCH 03/30] mm: remove CONFIG_HAVE_MEMBLOCK

On Wed, Sep 26, 2018 at 11:24:04AM +0200, Michal Hocko wrote:
> On Fri 14-09-18 15:10:18, Mike Rapoport wrote:
> > All architecures use memblock for early memory management. There is no need
> > for the CONFIG_HAVE_MEMBLOCK configuration option.
>
> git grep says
> arch/csky/Kconfig: select HAVE_MEMBLOCK

Not only that, there are other bootmem leftovers in csky.
I've sent the patch with the necessary fixups [1]

[1] https://lkml.kernel.org/lkml/20180926112744.GC4628@rapoport-lnx/

> > Signed-off-by: Mike Rapoport <[email protected]>
>
> Other than that
> Acked-by: Michal Hocko <[email protected]>
> --
> Michal Hocko
> SUSE Labs
>

--
Sincerely yours,
Mike.