2018-12-20 22:58:50

by Colin King

Subject: [PATCH][next] neighbour: remove stray semicolon

From: Colin Ian King <[email protected]>

Currently the stray semicolon means that the final term in the addition
is being missed. Fix this by removing it. Cleans up clang warning:

net/core/neighbour.c:2821:9: warning: expression result unused [-Wunused-value]

Fixes: 82cbb5c631a0 ("neighbour: register rtnl doit handler")
Signed-off-by: Colin Ian King <[email protected]>
---
net/core/neighbour.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 43687c9abe1d..1c4b7814ac32 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -2817,7 +2817,7 @@ static int neigh_get_reply(struct net *net, struct neighbour *neigh,
static inline size_t pneigh_nlmsg_size(void)
{
return NLMSG_ALIGN(sizeof(struct ndmsg))
- + nla_total_size(MAX_ADDR_LEN); /* NDA_DST */
+ + nla_total_size(MAX_ADDR_LEN) /* NDA_DST */
+ nla_total_size(1); /* NDA_PROTOCOL */
}

--
2.19.1

2018-12-20 17:12:34

by Roopa Prabhu

Subject: Re: [PATCH][next] neighbour: remove stray semicolon

On Thu, Dec 20, 2018 at 8:50 AM Colin King <[email protected]> wrote:
>
> From: Colin Ian King <[email protected]>
>
> Currently the stray semicolon means that the final term in the addition
> is being missed. Fix this by removing it. Cleans up clang warning:
>
> net/core/neighbour.c:2821:9: warning: expression result unused [-Wunused-value]
>
> Fixes: 82cbb5c631a0 ("neighbour: register rtnl doit handler")
> Signed-off-by: Colin Ian King <[email protected]>

Acked-By: Roopa Prabhu <[email protected]>

Thanks!.


> ---
> net/core/neighbour.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> index 43687c9abe1d..1c4b7814ac32 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -2817,7 +2817,7 @@ static int neigh_get_reply(struct net *net, struct neighbour *neigh,
> static inline size_t pneigh_nlmsg_size(void)
> {
> return NLMSG_ALIGN(sizeof(struct ndmsg))
> - + nla_total_size(MAX_ADDR_LEN); /* NDA_DST */
> + + nla_total_size(MAX_ADDR_LEN) /* NDA_DST */
> + nla_total_size(1); /* NDA_PROTOCOL */
> }
>
> --
> 2.19.1
>

2018-12-21 08:01:34

by David Miller

Subject: Re: [PATCH][next] neighbour: remove stray semicolon

From: Colin King <[email protected]>
Date: Thu, 20 Dec 2018 16:50:50 +0000

> From: Colin Ian King <[email protected]>
>
> Currently the stray semicolon means that the final term in the addition
> is being missed. Fix this by removing it. Cleans up clang warning:
>
> net/core/neighbour.c:2821:9: warning: expression result unused [-Wunused-value]
>
> Fixes: 82cbb5c631a0 ("neighbour: register rtnl doit handler")
> Signed-off-by: Colin Ian King <[email protected]>

Applied, thanks Colin.