1999-11-05 18:10:43

by Linus Torvalds

[permalink] [raw]
Subject: Re: EISA i/o mem & ioremap vs isa_memcpy

On Thu, 4 Nov 1999, Paul Gortmaker wrote:
> My question is: Does adding the isa_ prefix to the memcpy (and readb &
> friends) make sense for these EISA cases or should I just do the ioremap()
> unconditionally and not use the isa_ prefix. I tend to prefer the latter.

Just do the ioremap() unconditionally.

Note that the isa_xxxx() functions are for old drivers that do NOT know
about ioremap(), and think that the ISA space is always mapped. Think of
it as a band-aid for stupid drivers, making it easier to bring them up to
working order. But the "ioremap()" approach is always the right one.