2019-06-18 07:42:26

by Ding Xiang

Subject: [PATCH] Arm: zx: remove redundant dev_err message

devm_ioremap_resource already contains error message, so remove
the redundant dev_err message

Signed-off-by: Ding Xiang <[email protected]>
---
arch/arm/mach-zx/zx296702-pm-domain.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c
index 7a08bf9d..ac44ea8 100644
--- a/arch/arm/mach-zx/zx296702-pm-domain.c
+++ b/arch/arm/mach-zx/zx296702-pm-domain.c
@@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev)
}

pcubase = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(pcubase)) {
- dev_err(&pdev->dev, "ioremap fail.\n");
+ if (IS_ERR(pcubase))
return -EIO;
- }

for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i)
pm_genpd_init(zx296702_pm_domains[i], NULL, false);
--
1.9.1

2019-06-18 13:48:28

by Shawn Guo

Subject: Re: [PATCH] Arm: zx: remove redundant dev_err message

On Tue, Jun 18, 2019 at 03:39:01PM +0800, Ding Xiang wrote:
> devm_ioremap_resource already contains error message, so remove
> the redundant dev_err message
>
> Signed-off-by: Ding Xiang <[email protected]>

Acked-by: Shawn Guo <[email protected]>

Arnd, Olof,

Can you please apply it to arm-soc tree? Thanks.

Shawn

> ---
> arch/arm/mach-zx/zx296702-pm-domain.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c
> index 7a08bf9d..ac44ea8 100644
> --- a/arch/arm/mach-zx/zx296702-pm-domain.c
> +++ b/arch/arm/mach-zx/zx296702-pm-domain.c
> @@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev)
> }
>
> pcubase = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(pcubase)) {
> - dev_err(&pdev->dev, "ioremap fail.\n");
> + if (IS_ERR(pcubase))
> return -EIO;
> - }
>
> for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i)
> pm_genpd_init(zx296702_pm_domains[i], NULL, false);
> --
> 1.9.1
>
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

2019-06-18 13:53:37

by Russell King (Oracle)

Subject: Re: [PATCH] Arm: zx: remove redundant dev_err message

On Tue, Jun 18, 2019 at 09:46:36PM +0800, Shawn Guo wrote:
> On Tue, Jun 18, 2019 at 03:39:01PM +0800, Ding Xiang wrote:
> > devm_ioremap_resource already contains error message, so remove
> > the redundant dev_err message
> >
> > Signed-off-by: Ding Xiang <[email protected]>
>
> Acked-by: Shawn Guo <[email protected]>
>
> Arnd, Olof,
>
> Can you please apply it to arm-soc tree? Thanks.
>
> Shawn
>
> > ---
> > arch/arm/mach-zx/zx296702-pm-domain.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c
> > index 7a08bf9d..ac44ea8 100644
> > --- a/arch/arm/mach-zx/zx296702-pm-domain.c
> > +++ b/arch/arm/mach-zx/zx296702-pm-domain.c
> > @@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev)
> > }
> >
> > pcubase = devm_ioremap_resource(&pdev->dev, res);
> > - if (IS_ERR(pcubase)) {
> > - dev_err(&pdev->dev, "ioremap fail.\n");
> > + if (IS_ERR(pcubase))
> > return -EIO;

Shouldn't the error return also get fixed?

> > - }
> >
> > for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i)
> > pm_genpd_init(zx296702_pm_domains[i], NULL, false);
> > --
> > 1.9.1
> >
> >
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > [email protected]
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up