2019-07-04 03:00:15

by Hariprasad Kelam

Subject: [PATCH] net: ethernet: allwinner: Remove unneeded memset

Remove unneeded memset as alloc_etherdev is using kvzalloc which uses
__GFP_ZERO flag

Signed-off-by: Hariprasad Kelam <[email protected]>
---
drivers/net/ethernet/allwinner/sun4i-emac.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c
index 9e06dff..6253e5e 100644
--- a/drivers/net/ethernet/allwinner/sun4i-emac.c
+++ b/drivers/net/ethernet/allwinner/sun4i-emac.c
@@ -818,7 +818,6 @@ static int emac_probe(struct platform_device *pdev)
SET_NETDEV_DEV(ndev, &pdev->dev);

db = netdev_priv(ndev);
- memset(db, 0, sizeof(*db));

db->dev = &pdev->dev;
db->ndev = ndev;
--
2.7.4

2019-07-05 22:28:12

by David Miller

Subject: Re: [PATCH] net: ethernet: allwinner: Remove unneeded memset

From: Hariprasad Kelam <[email protected]>
Date: Thu, 4 Jul 2019 08:29:06 +0530

> Remove unneeded memset as alloc_etherdev is using kvzalloc which uses
> __GFP_ZERO flag
>
> Signed-off-by: Hariprasad Kelam <[email protected]>

Applied.