2019-09-09 23:47:10

by Masahiro Yamada

Subject: [PATCH] module: remove unneeded casts in cmp_name()

You can pass opaque pointers directly.

I also renamed 'va' and 'vb' into more meaningful arguments.

Signed-off-by: Masahiro Yamada <[email protected]>
---

kernel/module.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index 62e49ead0237..a2db612d039e 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -544,12 +544,9 @@ static const char *kernel_symbol_name(const struct kernel_symbol *sym)
#endif
}

-static int cmp_name(const void *va, const void *vb)
+static int cmp_name(const void *name, const void *sym)
{
- const char *a;
- const struct kernel_symbol *b;
- a = va; b = vb;
- return strcmp(a, kernel_symbol_name(b));
+ return strcmp(name, kernel_symbol_name(sym));
}

static bool find_exported_symbol_in_section(const struct symsearch *syms,
--
2.17.1

2019-09-11 12:35:19

by Jessica Yu

Subject: Re: [PATCH] module: remove unneeded casts in cmp_name()

+++ Masahiro Yamada [09/09/19 20:39 +0900]:
>You can pass opaque pointers directly.
>
>I also renamed 'va' and 'vb' into more meaningful arguments.
>
>Signed-off-by: Masahiro Yamada <[email protected]>

Looks good, I'll queue this up in modules-next.

Thanks!

Jessica