2019-10-23 06:26:46

by Yue Haibing

[permalink] [raw]
Subject: [PATCH -next] virtiofs: remove unused variable 'fc'

fs/fuse/virtio_fs.c:983:20: warning:
variable fc set but not used [-Wunused-but-set-variable]

It is not used since commit 7ee1e2e631db ("virtiofs:
No need to check fpq->connected state")

Signed-off-by: YueHaibing <[email protected]>
---
fs/fuse/virtio_fs.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index 2de8fc0..a5c8604 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -980,7 +980,6 @@ __releases(fiq->lock)
{
unsigned int queue_id = VQ_REQUEST; /* TODO multiqueue */
struct virtio_fs *fs;
- struct fuse_conn *fc;
struct fuse_req *req;
struct virtio_fs_vq *fsvq;
int ret;
@@ -993,7 +992,6 @@ __releases(fiq->lock)
spin_unlock(&fiq->lock);

fs = fiq->priv;
- fc = fs->vqs[queue_id].fud->fc;

pr_debug("%s: opcode %u unique %#llx nodeid %#llx in.len %u out.len %u\n",
__func__, req->in.h.opcode, req->in.h.unique,
--
2.7.4



2019-10-24 00:49:55

by Stefan Hajnoczi

[permalink] [raw]
Subject: Re: [PATCH -next] virtiofs: remove unused variable 'fc'

On Wed, Oct 23, 2019 at 02:21:30PM +0800, YueHaibing wrote:
> fs/fuse/virtio_fs.c:983:20: warning:
> variable fc set but not used [-Wunused-but-set-variable]
>
> It is not used since commit 7ee1e2e631db ("virtiofs:
> No need to check fpq->connected state")
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> fs/fuse/virtio_fs.c | 2 --
> 1 file changed, 2 deletions(-)

Reviewed-by: Stefan Hajnoczi <[email protected]>


Attachments:
(No filename) (449.00 B)
signature.asc (499.00 B)
Download all attachments