2020-01-21 08:35:15

by Alex Shi

[permalink] [raw]
Subject: [PATCH] lib/ida: remove abandoned macros

3 IDA_ started macros aren't used from commit f32f004cddf8 ("ida: Convert
to XArray"). so better to remove them.

Signed-off-by: Alex Shi <[email protected]>
Cc: Matthew Wilcox <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Richard Fontana <[email protected]>
Cc: Armijn Hemel <[email protected]>
Cc: [email protected]
---
lib/radix-tree.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/lib/radix-tree.c b/lib/radix-tree.c
index c8fa1d274530..2ee6ae3b0ade 100644
--- a/lib/radix-tree.c
+++ b/lib/radix-tree.c
@@ -56,14 +56,6 @@
#define IDR_PRELOAD_SIZE (IDR_MAX_PATH * 2 - 1)

/*
- * The IDA is even shorter since it uses a bitmap at the last level.
- */
-#define IDA_INDEX_BITS (8 * sizeof(int) - 1 - ilog2(IDA_BITMAP_BITS))
-#define IDA_MAX_PATH (DIV_ROUND_UP(IDA_INDEX_BITS, \
- RADIX_TREE_MAP_SHIFT))
-#define IDA_PRELOAD_SIZE (IDA_MAX_PATH * 2 - 1)
-
-/*
* Per-cpu pool of preloaded nodes
*/
struct radix_tree_preload {
--
1.8.3.1


2020-01-31 12:07:22

by Matthew Wilcox

[permalink] [raw]
Subject: Re: [PATCH] lib/ida: remove abandoned macros

On Tue, Jan 21, 2020 at 04:34:05PM +0800, Alex Shi wrote:
> 3 IDA_ started macros aren't used from commit f32f004cddf8 ("ida: Convert
> to XArray"). so better to remove them.

Thanks, applied.