2020-01-21 10:26:52

by Alex Shi

[permalink] [raw]
Subject: [PATCH] fs/quota: remove unused macro

__QUOTA_V2_PARANOIA macro is never used. better to remove it.

Signed-off-by: Alex Shi <[email protected]>
Cc: Jan Kara <[email protected]>
Cc: [email protected]
---
fs/quota/quota_v2.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/quota/quota_v2.c b/fs/quota/quota_v2.c
index 53429c29c784..58fc2a7c7fd1 100644
--- a/fs/quota/quota_v2.c
+++ b/fs/quota/quota_v2.c
@@ -22,8 +22,6 @@
MODULE_DESCRIPTION("Quota format v2 support");
MODULE_LICENSE("GPL");

-#define __QUOTA_V2_PARANOIA
-
static void v2r0_mem2diskdqb(void *dp, struct dquot *dquot);
static void v2r0_disk2memdqb(struct dquot *dquot, void *dp);
static int v2r0_is_id(void *dp, struct dquot *dquot);
--
1.8.3.1


2020-01-21 16:24:14

by Jan Kara

[permalink] [raw]
Subject: Re: [PATCH] fs/quota: remove unused macro

On Tue 21-01-20 18:25:34, Alex Shi wrote:
> __QUOTA_V2_PARANOIA macro is never used. better to remove it.
>
> Signed-off-by: Alex Shi <[email protected]>
> Cc: Jan Kara <[email protected]>
> Cc: [email protected]

Thanks. I've merged the patch.

Honza

> ---
> fs/quota/quota_v2.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/quota/quota_v2.c b/fs/quota/quota_v2.c
> index 53429c29c784..58fc2a7c7fd1 100644
> --- a/fs/quota/quota_v2.c
> +++ b/fs/quota/quota_v2.c
> @@ -22,8 +22,6 @@
> MODULE_DESCRIPTION("Quota format v2 support");
> MODULE_LICENSE("GPL");
>
> -#define __QUOTA_V2_PARANOIA
> -
> static void v2r0_mem2diskdqb(void *dp, struct dquot *dquot);
> static void v2r0_disk2memdqb(struct dquot *dquot, void *dp);
> static int v2r0_is_id(void *dp, struct dquot *dquot);
> --
> 1.8.3.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR