2020-01-21 10:27:39

by Alex Shi

[permalink] [raw]
Subject: [PATCH] proc: remove unused macro

KPMBITS is never used from it was introduced. better to remove it.

Signed-off-by: Alex Shi <[email protected]>
Cc: Alexey Dobriyan <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: David Hildenbrand <[email protected]>
Cc: "Michael S. Tsirkin" <[email protected]>
Cc: Pankaj gupta <[email protected]>
Cc: Konstantin Khlebnikov <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
fs/proc/page.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/proc/page.c b/fs/proc/page.c
index 7c952ee732e6..c4b1005a82bc 100644
--- a/fs/proc/page.c
+++ b/fs/proc/page.c
@@ -19,7 +19,6 @@

#define KPMSIZE sizeof(u64)
#define KPMMASK (KPMSIZE - 1)
-#define KPMBITS (KPMSIZE * BITS_PER_BYTE)

/* /proc/kpagecount - an array exposing page counts
*
--
1.8.3.1


2020-01-21 10:30:07

by David Hildenbrand

[permalink] [raw]
Subject: Re: [PATCH] proc: remove unused macro

On 21.01.20 11:25, Alex Shi wrote:
> KPMBITS is never used from it was introduced. better to remove it.

I suggest

"fs/proc/page.c: remove unused macro KPMBITS

KPMBITS was never used since it was introduced in commit 3c3fc71c8cfa
("mm: introduce idle page tracking"). Let's remove it.
"

Reviewed-by: David Hildenbrand <[email protected]>

>
> Signed-off-by: Alex Shi <[email protected]>
> Cc: Alexey Dobriyan <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Cc: David Hildenbrand <[email protected]>
> Cc: "Michael S. Tsirkin" <[email protected]>
> Cc: Pankaj gupta <[email protected]>
> Cc: Konstantin Khlebnikov <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> fs/proc/page.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/proc/page.c b/fs/proc/page.c
> index 7c952ee732e6..c4b1005a82bc 100644
> --- a/fs/proc/page.c
> +++ b/fs/proc/page.c
> @@ -19,7 +19,6 @@
>
> #define KPMSIZE sizeof(u64)
> #define KPMMASK (KPMSIZE - 1)
> -#define KPMBITS (KPMSIZE * BITS_PER_BYTE)
>
> /* /proc/kpagecount - an array exposing page counts
> *
>


--
Thanks,

David / dhildenb