2020-05-01 15:41:19

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH 02/14] docs: add bus-virt-phys-mapping.txt to core-api

This describes an old interface used prior the new DMA-API
interfaces. Add it to the core-api guide, just after the
DMA stuff.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---
.../bus-virt-phys-mapping.rst} | 0
Documentation/core-api/index.rst | 1 +
2 files changed, 1 insertion(+)
rename Documentation/{bus-virt-phys-mapping.txt => core-api/bus-virt-phys-mapping.rst} (100%)

diff --git a/Documentation/bus-virt-phys-mapping.txt b/Documentation/core-api/bus-virt-phys-mapping.rst
similarity index 100%
rename from Documentation/bus-virt-phys-mapping.txt
rename to Documentation/core-api/bus-virt-phys-mapping.rst
diff --git a/Documentation/core-api/index.rst b/Documentation/core-api/index.rst
index c00aef843341..b70039d458a7 100644
--- a/Documentation/core-api/index.rst
+++ b/Documentation/core-api/index.rst
@@ -84,6 +84,7 @@ more memory-management documentation in :doc:`/vm/index`.
dma-api-howto
dma-attributes
dma-isa-lpc
+ bus-virt-phys-mapping
mm-api
genalloc
pin_user_pages
--
2.25.4


2020-05-15 17:55:12

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH 02/14] docs: add bus-virt-phys-mapping.txt to core-api

On Fri, 1 May 2020 17:37:46 +0200
Mauro Carvalho Chehab <[email protected]> wrote:

> This describes an old interface used prior the new DMA-API
> interfaces. Add it to the core-api guide, just after the
> DMA stuff.
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> ---
> .../bus-virt-phys-mapping.rst} | 0
> Documentation/core-api/index.rst | 1 +
> 2 files changed, 1 insertion(+)
> rename Documentation/{bus-virt-phys-mapping.txt => core-api/bus-virt-phys-mapping.rst} (100%)

For this one, I think we should maybe just delete the file. It contains a
warning from *20 years ago* saying not to use it, and talks about
functions like isa_readl() that haven't existed i the kernel for some
time. Is there any reason to keep dragging it around?

jon

2020-05-22 04:24:24

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [PATCH 02/14] docs: add bus-virt-phys-mapping.txt to core-api

Em Fri, 15 May 2020 11:53:21 -0600
Jonathan Corbet <[email protected]> escreveu:

> On Fri, 1 May 2020 17:37:46 +0200
> Mauro Carvalho Chehab <[email protected]> wrote:
>
> > This describes an old interface used prior the new DMA-API
> > interfaces. Add it to the core-api guide, just after the
> > DMA stuff.
> >
> > Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> > ---
> > .../bus-virt-phys-mapping.rst} | 0
> > Documentation/core-api/index.rst | 1 +
> > 2 files changed, 1 insertion(+)
> > rename Documentation/{bus-virt-phys-mapping.txt => core-api/bus-virt-phys-mapping.rst} (100%)
>
> For this one, I think we should maybe just delete the file. It contains a
> warning from *20 years ago* saying not to use it, and talks about
> functions like isa_readl() that haven't existed i the kernel for some
> time. Is there any reason to keep dragging it around?

Except for "keeping it for historical reasons" (as mentioned at the
file), I don't see any reason why to keep it.

It might be useful if someone wants to port some OOT code based on
a legacy kernel.

Yet, if you prefer to just trash it, I'm ok with that.

Thanks,
Mauro