2020-10-12 02:16:01

by Clément Péron

Subject: [PATCH] arm64: dts: allwinner: beelink-gs1: Update LED power node

Beelink GS1 LED trigger a warning when running dtbs_check.

Update the node with a valid pattern property.

Also add the function and the color of the LED and drop the
label which is deprecated.

Signed-off-by: Clément Péron <[email protected]>
---
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
index 3f7ceeb1a767..f506d6fa8017 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
@@ -7,6 +7,7 @@
#include "sun50i-h6-cpu-opp.dtsi"

#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>

/ {
model = "Beelink GS1";
@@ -43,8 +44,9 @@ ext_osc32k: ext_osc32k_clk {
leds {
compatible = "gpio-leds";

- power {
- label = "beelink:white:power";
+ led-0 {
+ function = LED_FUNCTION_POWER;
+ color = LED_COLOR_ID_WHITE;
gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
default-state = "on";
};
--
2.25.1

2020-10-12 02:18:30

by Clément Péron

Subject: Re: [PATCH] arm64: dts: allwinner: beelink-gs1: Update LED power node

Hi,

On Sun, 11 Oct 2020 at 23:14, Clément Péron <[email protected]> wrote:
>
> Beelink GS1 LED trigger a warning when running dtbs_check.
>
> Update the node with a valid pattern property.
>
> Also add the function and the color of the LED and drop the
> label which is deprecated.
>
> Signed-off-by: Clément Péron <[email protected]>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> index 3f7ceeb1a767..f506d6fa8017 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> @@ -7,6 +7,7 @@
> #include "sun50i-h6-cpu-opp.dtsi"
>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
>
> / {
> model = "Beelink GS1";
> @@ -43,8 +44,9 @@ ext_osc32k: ext_osc32k_clk {
> leds {
> compatible = "gpio-leds";
>
> - power {
> - label = "beelink:white:power";
> + led-0 {
> + function = LED_FUNCTION_POWER;
> + color = LED_COLOR_ID_WHITE;
color = <LED_COLOR_ID_WHITE>;

Sorry, I will send a v2.

Clement

> gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
> default-state = "on";
> };
> --
> 2.25.1
>