2020-11-10 09:44:51

by Bartosz Golaszewski

Subject: [PATCH] rtc: destroy mutex when releasing the device

From: Bartosz Golaszewski <[email protected]>

Not destroying mutexes doesn't lead to resource leak but it's the correct
thing to do for mutex debugging accounting.

Signed-off-by: Bartosz Golaszewski <[email protected]>
---
drivers/rtc/class.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c
index 7c88d190c51f..e09b3f34ffdc 100644
--- a/drivers/rtc/class.c
+++ b/drivers/rtc/class.c
@@ -28,6 +28,7 @@ static void rtc_device_release(struct device *dev)
struct rtc_device *rtc = to_rtc_device(dev);

ida_simple_remove(&rtc_ida, rtc->id);
+ mutex_destroy(&rtc->ops_lock);
kfree(rtc);
}

--
2.29.1

2020-11-17 23:03:59

by Alexandre Belloni

Subject: Re: [PATCH] rtc: destroy mutex when releasing the device

On Tue, 10 Nov 2020 10:42:05 +0100, Bartosz Golaszewski wrote:
> Not destroying mutexes doesn't lead to resource leak but it's the correct
> thing to do for mutex debugging accounting.

Applied, thanks!

[1/1] rtc: destroy mutex when releasing the device
commit: b3527837a60a5dcd0c16c28804b6ec9b47f15947

Best regards,
--
Alexandre Belloni <[email protected]>