2020-12-08 21:04:13

by Souptick Joarder

Subject: [PATCH] riscv: Fixed kernel test robot warning

Kernel test robot throws below warning -

arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
for 'asm_offsets' [-Wmissing-prototypes]
14 | void asm_offsets(void)
| ^~~~~~~~~~~

This patch should fixed it.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Souptick Joarder <[email protected]>
---
arch/riscv/kernel/asm-offsets.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/riscv/kernel/asm-offsets.c b/arch/riscv/kernel/asm-offsets.c
index db20344..b79ffa3 100644
--- a/arch/riscv/kernel/asm-offsets.c
+++ b/arch/riscv/kernel/asm-offsets.c
@@ -11,6 +11,8 @@
#include <asm/thread_info.h>
#include <asm/ptrace.h>

+void asm_offsets(void);
+
void asm_offsets(void)
{
OFFSET(TASK_THREAD_RA, task_struct, thread.ra);
--
1.9.1

2020-12-09 01:11:48

by Andreas Schwab

Subject: Re: [PATCH] riscv: Fixed kernel test robot warning

On Dez 09 2020, Souptick Joarder wrote:

> Kernel test robot throws below warning -
>
> arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
> for 'asm_offsets' [-Wmissing-prototypes]
> 14 | void asm_offsets(void)
> | ^~~~~~~~~~~
>
> This patch should fixed it.

Or rename it to main, like most other asm-offsets files.

Andreas.

--
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."