2021-01-15 04:34:58

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the amdgpu tree

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: unused variable 'dm' [-Wunused-variable]
5380 | struct amdgpu_display_manager *dm = &adev->dm;
| ^~

Caused by commit

98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-01-20 06:39:18

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the amdgpu tree

Hi all,

On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the amdgpu tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: unused variable 'dm' [-Wunused-variable]
> 5380 | struct amdgpu_display_manager *dm = &adev->dm;
> | ^~
>
> Caused by commit
>
> 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")

I am still getting this warning.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-01-21 03:26:01

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the amdgpu tree

Hi all,

On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell <[email protected]> wrote:
>
> On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell <[email protected]> wrote:
> >
> > After merging the amdgpu tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: unused variable 'dm' [-Wunused-variable]
> > 5380 | struct amdgpu_display_manager *dm = &adev->dm;
> > | ^~
> >
> > Caused by commit
> >
> > 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
>
> I am still getting this warning.

I now get this warning from the drm tree merge.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-01-21 03:33:22

by Alex Deucher

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the amdgpu tree

On Wed, Jan 20, 2021 at 7:53 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell <[email protected]> wrote:
> >
> > On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell <[email protected]> wrote:
> > >
> > > After merging the amdgpu tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
> > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: unused variable 'dm' [-Wunused-variable]
> > > 5380 | struct amdgpu_display_manager *dm = &adev->dm;
> > > | ^~
> > >
> > > Caused by commit
> > >
> > > 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
> >
> > I am still getting this warning.
>
> I now get this warning from the drm tree merge.

Bhawan sent out the fix today:
https://patchwork.freedesktop.org/patch/415092/

Alex

>
> --
> Cheers,
> Stephen Rothwell

2021-01-21 08:36:46

by Daniel Vetter

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the amdgpu tree

On Thu, Jan 21, 2021 at 4:07 AM Alex Deucher <[email protected]> wrote:
>
> On Wed, Jan 20, 2021 at 7:53 PM Stephen Rothwell <[email protected]> wrote:
> >
> > Hi all,
> >
> > On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell <[email protected]> wrote:
> > >
> > > On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell <[email protected]> wrote:
> > > >
> > > > After merging the amdgpu tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > >
> > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
> > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: unused variable 'dm' [-Wunused-variable]
> > > > 5380 | struct amdgpu_display_manager *dm = &adev->dm;
> > > > | ^~
> > > >
> > > > Caused by commit
> > > >
> > > > 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
> > >
> > > I am still getting this warning.
> >
> > I now get this warning from the drm tree merge.

Drat, I missed that when merging.

> Bhawan sent out the fix today:
> https://patchwork.freedesktop.org/patch/415092/

Applied directly to drm-next, thanks.
-Daniel

>
> Alex
>
> >
> > --
> > Cheers,
> > Stephen Rothwell
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel



--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch