2021-02-11 22:25:10

by Gabriel Krisman Bertazi

[permalink] [raw]
Subject: [PATCH 0/2] tiny fixes to watch_queue

Hi David,

You'll find here a couple of misc improvements to watch_queue
documentation and code.

Gabriel Krisman Bertazi (2):
watch_queue: Fold info_id initialization into init_watch
docs: watch_queue: Fix unit of the notification size field

Documentation/watch_queue.rst | 7 ++++---
include/linux/watch_queue.h | 2 +-
kernel/watch_queue.c | 5 ++++-
security/keys/keyctl.c | 3 +--
4 files changed, 10 insertions(+), 7 deletions(-)


2021-02-11 22:27:10

by Gabriel Krisman Bertazi

[permalink] [raw]
Subject: [PATCH 2/2] docs: watch_queue: Fix unit of the notification size field

Looking at the code and other documentation, the unit of size is
bytes. Previously, the same documentation says bytes.

Signed-off-by: Gabriel Krisman Bertazi <[email protected]>
Documentation/watch_queue.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/watch_queue.rst b/Documentation/watch_queue.rst
index 426038e10276..75adb1874a0f 100644
--- a/Documentation/watch_queue.rst
+++ b/Documentation/watch_queue.rst
@@ -215,7 +215,7 @@ the following function should be used::

The notification should be preformatted and a pointer to the header (``n``)
should be passed in. The notification may be larger than this and the size in
-units of buffer slots is noted in ``n->info & WATCH_INFO_LENGTH``.
+bytes is noted in ``n->info & WATCH_INFO_LENGTH``.

The ``cred`` struct indicates the credentials of the source (subject) and is
passed to the LSMs, such as SELinux, to allow or suppress the recording of the