2021-02-15 14:42:15

by Alaa Emad

[permalink] [raw]
Subject: [PATCH resend] staging: hikey9xx: hi6421-spmi-pmic: fixing

This patch fix the following issues in hi6421-spmi-pmic.c file:

drivers/staging/hikey9xx/hi6421-spmi-pmic.c:51: WARNING: please, no space before tabs
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:52: WARNING: please, no space before tabs
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:53: WARNING: please, no space before tabs
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:69: WARNING: please, no space before tabs
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:180: CHECK: Alignment should match open parenthesis
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:238: CHECK: Alignment should match open parenthesis


Signed-off-by: Alaa Emad <[email protected]>

---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
index 9c5e113e1a81..626140cb96f2 100644
--- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
+++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
@@ -48,9 +48,9 @@ enum hi6421_spmi_pmic_irq_list {
/*
* The IRQs are mapped as:
*
- * ====================== ============= ============ =====
- * IRQ MASK REGISTER IRQ REGISTER BIT
- * ====================== ============= ============ =====
+ * ====================== ============= ============ =====
+ * IRQ MASK REGISTER IRQ REGISTER BIT
+ * ====================== ============= ============ =====
* OTMP 0x0202 0x212 bit 0
* VBUS_CONNECT 0x0202 0x212 bit 1
* VBUS_DISCONNECT 0x0202 0x212 bit 2
@@ -66,7 +66,7 @@ enum hi6421_spmi_pmic_irq_list {
* SIM0_HPD_F 0x0203 0x213 bit 3
* SIM1_HPD_R 0x0203 0x213 bit 4
* SIM1_HPD_F 0x0203 0x213 bit 5
- * ====================== ============= ============ =====
+ * ====================== ============= ============ =====
*/
#define SOC_PMIC_IRQ_MASK_0_ADDR 0x0202
#define SOC_PMIC_IRQ0_ADDR 0x0212
@@ -177,7 +177,7 @@ static void hi6421_spmi_pmic_irq_init(struct hi6421_spmi_pmic *ddata)

for (i = 0; i < HISI_IRQ_ARRAY; i++)
regmap_write(ddata->regmap, SOC_PMIC_IRQ_MASK_0_ADDR + i,
- HISI_MASK);
+ HISI_MASK);

for (i = 0; i < HISI_IRQ_ARRAY; i++) {
regmap_read(ddata->regmap, SOC_PMIC_IRQ0_ADDR + i, &pending);
@@ -235,7 +235,7 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev)
return -ENOMEM;

ddata->domain = irq_domain_add_simple(np, HISI_IRQ_NUM, 0,
- &hi6421_spmi_domain_ops, ddata);
+ &hi6421_spmi_domain_ops, ddata);
if (!ddata->domain) {
dev_err(dev, "Failed to create IRQ domain\n");
return -ENODEV;
--
2.25.1


2021-02-15 14:55:37

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH resend] staging: hikey9xx: hi6421-spmi-pmic: fixing

On Mon, Feb 15, 2021 at 04:36:52PM +0200, Alaa Emad wrote:
> This patch fix the following issues in hi6421-spmi-pmic.c file:
>
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c:51: WARNING: please, no space before tabs
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c:52: WARNING: please, no space before tabs
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c:53: WARNING: please, no space before tabs
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c:69: WARNING: please, no space before tabs
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c:180: CHECK: Alignment should match open parenthesis
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c:238: CHECK: Alignment should match open parenthesis
>
>
> Signed-off-by: Alaa Emad <[email protected]>
>
> ---
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

Why is this a "resend"? What caused it to be needed to be resent?

And your subject line is really odd, how does it match up with other
commits for this file?

thanks,

greg k-h

2021-02-15 15:25:08

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH resend] staging: hikey9xx: hi6421-spmi-pmic: fixing

On Mon, Feb 15, 2021 at 05:02:50PM +0200, Alaa Emad wrote:
> sorry ,i thought it needs to change the description so i resent .

If so, then say what you changed below the --- line and make it a v2
patch, like the Documentation tells you to do, right?

> please guide me how to fix this or it is good?

No, see above.

thanks,

greg k-h