2021-02-16 12:44:52

by Alaa Emad

[permalink] [raw]
Subject: [PATCH v2] staging: hikey9xx: fix styling issues

In hi6421-spmi-pmic.c, there are some warnings and Check:

"WARNING: please, no space before tabs" in lines 51,52,53 and 69.
"CHECK: Alignment should match open parenthesis" in lines 180 and 238.

Signed-off-by: Alaa Emad <[email protected]>
---
Changes in v2:
- Make the commit message more clearer.
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
index 9c5e113e1a81..626140cb96f2 100644
--- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
+++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
@@ -48,9 +48,9 @@ enum hi6421_spmi_pmic_irq_list {
/*
* The IRQs are mapped as:
*
- * ====================== ============= ============ =====
- * IRQ MASK REGISTER IRQ REGISTER BIT
- * ====================== ============= ============ =====
+ * ====================== ============= ============ =====
+ * IRQ MASK REGISTER IRQ REGISTER BIT
+ * ====================== ============= ============ =====
* OTMP 0x0202 0x212 bit 0
* VBUS_CONNECT 0x0202 0x212 bit 1
* VBUS_DISCONNECT 0x0202 0x212 bit 2
@@ -66,7 +66,7 @@ enum hi6421_spmi_pmic_irq_list {
* SIM0_HPD_F 0x0203 0x213 bit 3
* SIM1_HPD_R 0x0203 0x213 bit 4
* SIM1_HPD_F 0x0203 0x213 bit 5
- * ====================== ============= ============ =====
+ * ====================== ============= ============ =====
*/
#define SOC_PMIC_IRQ_MASK_0_ADDR 0x0202
#define SOC_PMIC_IRQ0_ADDR 0x0212
@@ -177,7 +177,7 @@ static void hi6421_spmi_pmic_irq_init(struct hi6421_spmi_pmic *ddata)

for (i = 0; i < HISI_IRQ_ARRAY; i++)
regmap_write(ddata->regmap, SOC_PMIC_IRQ_MASK_0_ADDR + i,
- HISI_MASK);
+ HISI_MASK);

for (i = 0; i < HISI_IRQ_ARRAY; i++) {
regmap_read(ddata->regmap, SOC_PMIC_IRQ0_ADDR + i, &pending);
@@ -235,7 +235,7 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev)
return -ENOMEM;

ddata->domain = irq_domain_add_simple(np, HISI_IRQ_NUM, 0,
- &hi6421_spmi_domain_ops, ddata);
+ &hi6421_spmi_domain_ops, ddata);
if (!ddata->domain) {
dev_err(dev, "Failed to create IRQ domain\n");
return -ENODEV;
--
2.25.1


2021-02-19 08:14:44

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2] staging: hikey9xx: fix styling issues

On Tue, Feb 16, 2021 at 02:42:55PM +0200, Alaa Emad wrote:
> In hi6421-spmi-pmic.c, there are some warnings and Check:
>
> "WARNING: please, no space before tabs" in lines 51,52,53 and 69.
> "CHECK: Alignment should match open parenthesis" in lines 180 and 238.
>
> Signed-off-by: Alaa Emad <[email protected]>

That is doing 2 different things in the same patch, please make this a
patch series and do only one type of logical thing per patch and resend
them.

thanks,

greg k-h