2021-02-22 10:01:15

by Jiapeng Chong

Subject: [PATCH] net/mlx5: remove unneeded semicolon

Fix the following coccicheck warnings:

./drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c:495:2-3: Unneeded
semicolon.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
index c2ba41b..60a6328 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
@@ -492,7 +492,7 @@ static int mlx5_sf_esw_event(struct notifier_block *nb, unsigned long event, voi
break;
default:
break;
- };
+ }

return 0;
}
--
1.8.3.1

2021-02-22 10:10:06

by Parav Pandit

Subject: RE: [PATCH] net/mlx5: remove unneeded semicolon

> From: Jiapeng Chong <[email protected]>
> Sent: Monday, February 22, 2021 3:27 PM
>
> Fix the following coccicheck warnings:
>
> ./drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c:495:2-3: Unneeded
> semicolon.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> index c2ba41b..60a6328 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> @@ -492,7 +492,7 @@ static int mlx5_sf_esw_event(struct notifier_block
> *nb, unsigned long event, voi
> break;
> default:
> break;
> - };
> + }
>
> return 0;
> }
> --
> 1.8.3.1

Reviewed-by: Parav Pandit <[email protected]>

2021-03-04 23:17:06

by Parav Pandit

Subject: RE: [PATCH] net/mlx5: remove unneeded semicolon

Hi Saeed,

> From: Parav Pandit <[email protected]>
> Sent: Monday, February 22, 2021 3:32 PM
>
>
> > From: Jiapeng Chong <[email protected]>
> > Sent: Monday, February 22, 2021 3:27 PM
> >
> > Fix the following coccicheck warnings:
> >
> > ./drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c:495:2-3:
> > Unneeded semicolon.
> >
> > Reported-by: Abaci Robot <[email protected]>
> > Signed-off-by: Jiapeng Chong <[email protected]>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > index c2ba41b..60a6328 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > @@ -492,7 +492,7 @@ static int mlx5_sf_esw_event(struct notifier_block
> > *nb, unsigned long event, voi
> > break;
> > default:
> > break;
> > - };
> > + }
> >
> > return 0;
> > }
> > --
> > 1.8.3.1
>
> Reviewed-by: Parav Pandit <[email protected]>

Will you take this patch [1] to your queue?

[1] https://lore.kernel.org/linux-rdma/1613987819-43161-1-git-send-email-jiapeng.chong@linux.alibaba.com/

2021-03-11 23:29:17

by Saeed Mahameed

Subject: Re: [PATCH] net/mlx5: remove unneeded semicolon

On Wed, 2021-03-03 at 08:52 +0000, Parav Pandit wrote:
> Hi Saeed,
>
> > From: Parav Pandit <[email protected]>
> > Sent: Monday, February 22, 2021 3:32 PM
> >
> >
> > > From: Jiapeng Chong <[email protected]>
> > > Sent: Monday, February 22, 2021 3:27 PM
> > >
> > > Fix the following coccicheck warnings:
> > >
> > > ./drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c:495:2-3:
> > > Unneeded semicolon.
> > >
> > > Reported-by: Abaci Robot <[email protected]>
> > > Signed-off-by: Jiapeng Chong <[email protected]>
> > > ---
> > >  drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > > b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > > index c2ba41b..60a6328 100644
> > > --- a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > > @@ -492,7 +492,7 @@ static int mlx5_sf_esw_event(struct
> > > notifier_block
> > > *nb, unsigned long event, voi
> > >                 break;
> > >         default:
> > >                 break;
> > > -       };
> > > +       }
> > >
> > >         return 0;
> > >  }
> > > --
> > > 1.8.3.1
> >
> > Reviewed-by: Parav Pandit <[email protected]>
>
> Will you take this patch [1] to your queue?
>
> [1]
> https://lore.kernel.org/linux-rdma/1613987819-43161-1-git-send-email-jiapeng.chong@linux.alibaba.com/

Applied to net-next-mlx5.
Thanks,
Saeed.