2021-04-07 21:01:33

by Vincenzo Frascino

[permalink] [raw]
Subject: [PATCH] arm64: mte: Remove unused mte_assign_mem_tag_range()

mte_assign_mem_tag_range() was added in commit 85f49cae4dfc
("arm64: mte: add in-kernel MTE helpers") in 5.11 but moved out of
mte.S by commit 2cb34276427a ("arm64: kasan: simplify and inline
MTE functions") in 5.12 and renamed to mte_set_mem_tag_range().
2cb34276427a did not delete the old function prototypes in mte.h.

Remove the unused prototype from mte.h.

Cc: Catalin Marinas <[email protected]>
Cc: Will Deacon <[email protected]>
Reported-by: Derrick McKee <[email protected]>
Signed-off-by: Vincenzo Frascino <[email protected]>
---
arch/arm64/include/asm/mte.h | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/arm64/include/asm/mte.h b/arch/arm64/include/asm/mte.h
index 9b557a457f24..387279540139 100644
--- a/arch/arm64/include/asm/mte.h
+++ b/arch/arm64/include/asm/mte.h
@@ -47,8 +47,6 @@ long get_mte_ctrl(struct task_struct *task);
int mte_ptrace_copy_tags(struct task_struct *child, long request,
unsigned long addr, unsigned long data);

-void mte_assign_mem_tag_range(void *addr, size_t size);
-
#else /* CONFIG_ARM64_MTE */

/* unused if !CONFIG_ARM64_MTE, silence the compiler */
@@ -84,10 +82,6 @@ static inline int mte_ptrace_copy_tags(struct task_struct *child,
return -EIO;
}

-static inline void mte_assign_mem_tag_range(void *addr, size_t size)
-{
-}
-
#endif /* CONFIG_ARM64_MTE */

#endif /* __ASSEMBLY__ */
--
2.30.2


2021-04-08 18:04:28

by Catalin Marinas

[permalink] [raw]
Subject: Re: [PATCH] arm64: mte: Remove unused mte_assign_mem_tag_range()

On Wed, 7 Apr 2021 14:38:17 +0100, Vincenzo Frascino wrote:
> mte_assign_mem_tag_range() was added in commit 85f49cae4dfc
> ("arm64: mte: add in-kernel MTE helpers") in 5.11 but moved out of
> mte.S by commit 2cb34276427a ("arm64: kasan: simplify and inline
> MTE functions") in 5.12 and renamed to mte_set_mem_tag_range().
> 2cb34276427a did not delete the old function prototypes in mte.h.
>
> Remove the unused prototype from mte.h.

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64: mte: Remove unused mte_assign_mem_tag_range()
https://git.kernel.org/arm64/c/df652a16a657

--
Catalin