2021-04-20 12:32:48

by Shubhankar Kuranagatti

Subject: [PATCH] drivers: target: target_core_pr.c: Fix tabspace error

Tabs have been used to replace spaces.
This is done to maintain code uniformity.

Signed-off-by: Shubhankar Kuranagatti <[email protected]>
---
drivers/target/target_core_pr.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c
index d4cc43afe05b..6538b2be1634 100644
--- a/drivers/target/target_core_pr.c
+++ b/drivers/target/target_core_pr.c
@@ -539,18 +539,18 @@ static int core_scsi3_pr_seq_non_holder(struct se_cmd *cmd, u32 pr_reg_type,
return 0;
}
} else if (we && registered_nexus) {
- /*
- * Reads are allowed for Write Exclusive locks
- * from all registrants.
- */
- if (cmd->data_direction == DMA_FROM_DEVICE) {
- pr_debug("Allowing READ CDB: 0x%02x for %s"
- " reservation\n", cdb[0],
- core_scsi3_pr_dump_type(pr_reg_type));
-
- return 0;
- }
- }
+ /*
+ * Reads are allowed for Write Exclusive locks
+ * from all registrants.
+ */
+ if (cmd->data_direction == DMA_FROM_DEVICE) {
+ pr_debug("Allowing READ CDB: 0x%02x for %s"
+ " reservation\n", cdb[0],
+ core_scsi3_pr_dump_type(pr_reg_type));
+
+ return 0;
+ }
+ }
pr_debug("%s Conflict for %sregistered nexus %s CDB: 0x%2x"
" for %s reservation\n", transport_dump_cmd_direction(cmd),
(registered_nexus) ? "" : "un",
--
2.17.1

2021-04-20 15:00:41

by Himanshu Madhani

Subject: Re: [PATCH] drivers: target: target_core_pr.c: Fix tabspace error

> On Apr 20, 2021, at 7:28 AM, Shubhankar Kuranagatti <[email protected]> wrote:
>
> Tabs have been used to replace spaces.
> This is done to maintain code uniformity.
>
> Signed-off-by: Shubhankar Kuranagatti <[email protected]>
> ---
> drivers/target/target_core_pr.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c
> index d4cc43afe05b..6538b2be1634 100644
> --- a/drivers/target/target_core_pr.c
> +++ b/drivers/target/target_core_pr.c
> @@ -539,18 +539,18 @@ static int core_scsi3_pr_seq_non_holder(struct se_cmd *cmd, u32 pr_reg_type,
> return 0;
> }
> } else if (we && registered_nexus) {
> - /*
> - * Reads are allowed for Write Exclusive locks
> - * from all registrants.
> - */
> - if (cmd->data_direction == DMA_FROM_DEVICE) {
> - pr_debug("Allowing READ CDB: 0x%02x for %s"
> - " reservation\n", cdb[0],
> - core_scsi3_pr_dump_type(pr_reg_type));
> -
> - return 0;
> - }
> - }
> + /*
> + * Reads are allowed for Write Exclusive locks
> + * from all registrants.
> + */
> + if (cmd->data_direction == DMA_FROM_DEVICE) {
> + pr_debug("Allowing READ CDB: 0x%02x for %s"
> + " reservation\n", cdb[0],
> + core_scsi3_pr_dump_type(pr_reg_type));
> +
> + return 0;
> + }
> + }

this last one has one too many tab.

> pr_debug("%s Conflict for %sregistered nexus %s CDB: 0x%2x"
> " for %s reservation\n", transport_dump_cmd_direction(cmd),
> (registered_nexus) ? "" : "un",
> --
> 2.17.1
>

--
Himanshu Madhani Oracle Linux Engineering