2021-04-27 22:43:21

by Thomas Bogendoerfer

[permalink] [raw]
Subject: [PATCH] dt-binding: interrupt-controller: Add missing interrupts property

Interrupts property is required, so add it.

Signed-off-by: Thomas Bogendoerfer <[email protected]>
---
.../bindings/interrupt-controller/idt,32434-pic.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/idt,32434-pic.yaml b/Documentation/devicetree/bindings/interrupt-controller/idt,32434-pic.yaml
index df5d8d1ead70..160ff4b07cac 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/idt,32434-pic.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/idt,32434-pic.yaml
@@ -22,6 +22,9 @@ properties:
reg:
maxItems: 1

+ interrupts:
+ maxItems: 1
+
interrupt-controller: true

required:
@@ -29,6 +32,7 @@ required:
- compatible
- reg
- interrupt-controller
+ - interrupts

additionalProperties: false

--
2.29.2


2021-04-28 22:17:45

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] dt-binding: interrupt-controller: Add missing interrupts property

On Wed, 28 Apr 2021 00:42:00 +0200, Thomas Bogendoerfer wrote:
> Interrupts property is required, so add it.
>
> Signed-off-by: Thomas Bogendoerfer <[email protected]>
> ---
> .../bindings/interrupt-controller/idt,32434-pic.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.example.dt.yaml: [email protected]: 'oneOf' conditional failed, one must be fixed:
'interrupts' is a required property
'interrupts-extended' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.yaml

See https://patchwork.ozlabs.org/patch/1470883

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

2021-04-28 22:43:52

by Thomas Bogendoerfer

[permalink] [raw]
Subject: Re: [PATCH] dt-binding: interrupt-controller: Add missing interrupts property

On Wed, Apr 28, 2021 at 05:15:09PM -0500, Rob Herring wrote:
> On Wed, 28 Apr 2021 00:42:00 +0200, Thomas Bogendoerfer wrote:
> > Interrupts property is required, so add it.
> >
> > Signed-off-by: Thomas Bogendoerfer <[email protected]>
> > ---
> > .../bindings/interrupt-controller/idt,32434-pic.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.example.dt.yaml: [email protected]: 'oneOf' conditional failed, one must be fixed:
> 'interrupts' is a required property
> 'interrupts-extended' is a required property
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.yaml

now I'm confused... is this a problem of your test ? make dt_binding_check
was ok with that change...

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]

2021-04-28 23:46:41

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] dt-binding: interrupt-controller: Add missing interrupts property

On Wed, Apr 28, 2021 at 5:42 PM Thomas Bogendoerfer
<[email protected]> wrote:
>
> On Wed, Apr 28, 2021 at 05:15:09PM -0500, Rob Herring wrote:
> > On Wed, 28 Apr 2021 00:42:00 +0200, Thomas Bogendoerfer wrote:
> > > Interrupts property is required, so add it.
> > >
> > > Signed-off-by: Thomas Bogendoerfer <[email protected]>
> > > ---
> > > .../bindings/interrupt-controller/idt,32434-pic.yaml | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.example.dt.yaml: [email protected]: 'oneOf' conditional failed, one must be fixed:
> > 'interrupts' is a required property
> > 'interrupts-extended' is a required property
> > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.yaml
>
> now I'm confused... is this a problem of your test ? make dt_binding_check
> was ok with that change...

You and me both. I'll look into it when I apply.

Rob

2021-04-29 21:02:50

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] dt-binding: interrupt-controller: Add missing interrupts property

On Wed, 28 Apr 2021 00:42:00 +0200, Thomas Bogendoerfer wrote:
> Interrupts property is required, so add it.
>
> Signed-off-by: Thomas Bogendoerfer <[email protected]>
> ---
> .../bindings/interrupt-controller/idt,32434-pic.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>

Applied, thanks!

All fine in my build, so not sure what happened to the bot...