2021-06-11 16:56:18

by Colin King

Subject: [PATCH][next] ALSA: i2c: tea6330t: Remove redundant initialization of variable err

From: Colin Ian King <[email protected]>

The variable err is being initialized with a value that is never read,
it is being updated later on. The assignment is redundant and can be
removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
sound/i2c/tea6330t.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/i2c/tea6330t.c b/sound/i2c/tea6330t.c
index 742d0f724375..037d6293f728 100644
--- a/sound/i2c/tea6330t.c
+++ b/sound/i2c/tea6330t.c
@@ -284,7 +284,7 @@ int snd_tea6330t_update_mixer(struct snd_card *card,
struct tea6330t *tea;
const struct snd_kcontrol_new *knew;
unsigned int idx;
- int err = -ENOMEM;
+ int err;
u8 default_treble, default_bass;
unsigned char bytes[7];

--
2.31.1

2021-06-12 07:36:16

by Takashi Iwai

Subject: Re: [PATCH][next] ALSA: i2c: tea6330t: Remove redundant initialization of variable err

On Fri, 11 Jun 2021 18:52:23 +0200,
Colin King wrote:
>
> From: Colin Ian King <[email protected]>
>
> The variable err is being initialized with a value that is never read,
> it is being updated later on. The assignment is redundant and can be
> removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Thanks, applied.


Takashi