2006-11-08 22:25:33

by Alexey Dobriyan

Subject: [PATCH] flexcop-usb.c: fix "&& 0xff" typos and ...

.. fix debug printk. Why, oh why, one would want to do

(u16 & 0xff) << 8

and print it with %02x format?

Signed-off-by: Alexey Dobriyan <[email protected]>
---

drivers/media/dvb/b2c2/flexcop-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/media/dvb/b2c2/flexcop-usb.c
+++ b/drivers/media/dvb/b2c2/flexcop-usb.c
@@ -246,7 +246,7 @@ static int flexcop_usb_i2c_req(struct fl
wIndex = (chipaddr << 8 ) | addr;

deb_i2c("i2c %2d: %02x %02x %02x %02x %02x %02x\n",func,request_type,req,
- ((wValue && 0xff) << 8),wValue >> 8,((wIndex && 0xff) << 8),wIndex >> 8);
+ wValue & 0xff, wValue >> 8, wIndex & 0xff, wIndex >> 8);

len = usb_control_msg(fc_usb->udev,pipe,
req,

2006-11-09 16:42:30

by Michael Ira Krufky

Subject: Re: [v4l-dvb-maintainer] [PATCH] flexcop-usb.c: fix "&& 0xff" typos and ...

Alexey Dobriyan wrote:
> .. fix debug printk. Why, oh why, one would want to do
>
> (u16 & 0xff) << 8
>
> and print it with %02x format?
>
> Signed-off-by: Alexey Dobriyan <[email protected]>

I spoke to Patrick in irc and confirmed the fix...

Acked-by: Patrick Boettcher <[email protected]>
Signed-off-by: Michael Krufky <[email protected]>

> ---
>
> drivers/media/dvb/b2c2/flexcop-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/media/dvb/b2c2/flexcop-usb.c
> +++ b/drivers/media/dvb/b2c2/flexcop-usb.c
> @@ -246,7 +246,7 @@ static int flexcop_usb_i2c_req(struct fl
> wIndex = (chipaddr << 8 ) | addr;
>
> deb_i2c("i2c %2d: %02x %02x %02x %02x %02x %02x\n",func,request_type,req,
> - ((wValue && 0xff) << 8),wValue >> 8,((wIndex && 0xff) << 8),wIndex >> 8);
> + wValue & 0xff, wValue >> 8, wIndex & 0xff, wIndex >> 8);
>
> len = usb_control_msg(fc_usb->udev,pipe,
> req,
>
>
> _______________________________________________
> v4l-dvb-maintainer mailing list
> [email protected]
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer


--
Michael Krufky