2006-11-11 00:49:54

by Nicolas Kaiser

Subject: [PATCH][TRIVIAL] drivers/ide: stray bracket

Stray bracket in debug code.

Signed-off-by: Nicolas Kaiser <[email protected]>
---

drivers/ide/legacy/hd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -uprN a/drivers/ide/legacy/hd.c b/drivers/ide/legacy/hd.c
--- a/drivers/ide/legacy/hd.c 2006-09-20 05:42:06.000000000 +0200
+++ b/drivers/ide/legacy/hd.c 2006-11-10 21:52:20.000000000 +0100
@@ -459,7 +459,7 @@ ok_to_read:
#ifdef DEBUG
printk("%s: read: sector %ld, remaining = %ld, buffer=%p\n",
req->rq_disk->disk_name, req->sector, req->nr_sectors,
- req->buffer+512));
+ req->buffer+512);
#endif
if (req->current_nr_sectors <= 0)
end_request(req, 1);

2006-11-11 13:16:20

by Alexey Dobriyan

Subject: Re: [PATCH][TRIVIAL] drivers/ide: stray bracket

On Sat, Nov 11, 2006 at 01:47:56AM +0100, Nicolas Kaiser wrote:
> Stray bracket in debug code.

> --- a/drivers/ide/legacy/hd.c 2006-09-20 05:42:06.000000000 +0200
> +++ b/drivers/ide/legacy/hd.c 2006-11-10 21:52:20.000000000 +0100
> @@ -459,7 +459,7 @@ ok_to_read:
> #ifdef DEBUG
> printk("%s: read: sector %ld, remaining = %ld, buffer=%p\n",
> req->rq_disk->disk_name, req->sector, req->nr_sectors,
> - req->buffer+512));
> + req->buffer+512);
> #endif

Just remove whole printk. It was broken for a looong time.

2006-11-11 16:23:03

by Nicolas Kaiser

Subject: Re: [PATCH][TRIVIAL] drivers/ide: stray bracket

* Alexey Dobriyan <[email protected]>:
> On Sat, Nov 11, 2006 at 01:47:56AM +0100, Nicolas Kaiser wrote:
> > Stray bracket in debug code.

> Just remove whole printk. It was broken for a looong time.

If you prefer it that way, here we go:
Remove debug code that was broken for long time.

Signed-off-by: Nicolas Kaiser <[email protected]>
---

drivers/ide/legacy/hd.c | 5 -----
1 file changed, 5 deletions(-)

diff -uprN a/drivers/ide/legacy/hd.c b/drivers/ide/legacy/hd.c
--- a/drivers/ide/legacy/hd.c 2006-09-20 05:42:06.000000000 +0200
+++ b/drivers/ide/legacy/hd.c 2006-11-11 17:11:28.000000000 +0100
@@ -456,11 +456,6 @@ ok_to_read:
req->errors = 0;
i = --req->nr_sectors;
--req->current_nr_sectors;
-#ifdef DEBUG
- printk("%s: read: sector %ld, remaining = %ld, buffer=%p\n",
- req->rq_disk->disk_name, req->sector, req->nr_sectors,
- req->buffer+512));
-#endif
if (req->current_nr_sectors <= 0)
end_request(req, 1);
if (i > 0) {