2021-07-09 15:31:47

by Colin King

Subject: [PATCH] ALSA: hda/ca0132: remove redundant initialization of variable status

From: Colin Ian King <[email protected]>

The variable status is being initialized with a value that is never
read, the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
sound/pci/hda/patch_ca0132.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index b66e7bdbf483..50ca72ee586e 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -2270,7 +2270,7 @@ static int dspio_send_scp_message(struct hda_codec *codec,
unsigned int *bytes_returned)
{
struct ca0132_spec *spec = codec->spec;
- int status = -1;
+ int status;
unsigned int scp_send_size = 0;
unsigned int total_size;
bool waiting_for_resp = false;
--
2.31.1

2021-07-12 09:16:19

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hda/ca0132: remove redundant initialization of variable status

On Fri, 09 Jul 2021 17:29:38 +0200,
Colin King wrote:
>
> From: Colin Ian King <[email protected]>
>
> The variable status is being initialized with a value that is never
> read, the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Thanks, applied.


Takashi