2006-11-29 22:35:40

by Mariusz Kozlowski

Subject: net: sk98lin bracket question

Hello,

Somewhere below is either one extra or one missing bracket. Any idea how to fix that?

Is the patch below correct?

--- linux-2.6.19-rc6-mm2-a/drivers/net/sk98lin/skgesirq.c 2006-11-16 05:03:40.000000000 +0100
+++ linux-2.6.19-rc6-mm2-b/drivers/net/sk98lin/skgesirq.c 2006-11-29 23:32:02.000000000 +0100
@@ -1319,7 +1319,7 @@ SK_BOOL AutoNeg) /* Is Auto-negotiation
SkXmPhyRead(pAC, IoC, Port, PHY_BCOM_INT_STAT, &Isrc);

#ifdef xDEBUG
- if ((Isrc & ~(PHY_B_IS_HCT | PHY_B_IS_LCT) ==
+ if ((Isrc & ~(PHY_B_IS_HCT | PHY_B_IS_LCT)) ==
(PHY_B_IS_SCR_S_ER | PHY_B_IS_RRS_CHANGE | PHY_B_IS_LRS_CHANGE)) {

SK_U32 Stat1, Stat2, Stat3;


PS. Who is the maintainer of this driver?

--
Regards,

Mariusz Kozlowski

2006-11-29 22:53:00

by Stephen Hemminger

Subject: Re: net: sk98lin bracket question

On Wed, 29 Nov 2006 23:35:07 +0100
Mariusz Kozlowski <[email protected]> wrote:

> Hello,
>
> Somewhere below is either one extra or one missing bracket. Any idea how to fix that?
>
> Is the patch below correct?
>
> --- linux-2.6.19-rc6-mm2-a/drivers/net/sk98lin/skgesirq.c 2006-11-16 05:03:40.000000000 +0100
> +++ linux-2.6.19-rc6-mm2-b/drivers/net/sk98lin/skgesirq.c 2006-11-29 23:32:02.000000000 +0100
> @@ -1319,7 +1319,7 @@ SK_BOOL AutoNeg) /* Is Auto-negotiation
> SkXmPhyRead(pAC, IoC, Port, PHY_BCOM_INT_STAT, &Isrc);
>
> #ifdef xDEBUG
> - if ((Isrc & ~(PHY_B_IS_HCT | PHY_B_IS_LCT) ==
> + if ((Isrc & ~(PHY_B_IS_HCT | PHY_B_IS_LCT)) ==
> (PHY_B_IS_SCR_S_ER | PHY_B_IS_RRS_CHANGE | PHY_B_IS_LRS_CHANGE)) {
>
> SK_U32 Stat1, Stat2, Stat3;
>
>
> PS. Who is the maintainer of this driver?
>

Nobody is maintaining this driver, it is being obsoleted and replaced by skge.

--
Stephen Hemminger <[email protected]>