2021-10-12 11:56:33

by Vegard Nossum

[permalink] [raw]
Subject: [PATCH] drm/panel: olimex-lcd-olinuxino: select CRC32

Fix the following build/link error by adding a dependency on the CRC32
routines:

ld: drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.o: in function `lcd_olinuxino_probe':
panel-olimex-lcd-olinuxino.c:(.text+0x303): undefined reference to `crc32_le'

Fixes: 17fd7a9d324fd ("drm/panel: Add support for Olimex LCD-OLinuXino panel")
Cc: Arnd Bergmann <[email protected]>
Signed-off-by: Vegard Nossum <[email protected]>
---
drivers/gpu/drm/panel/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index beb581b96ecdc..418638e6e3b0a 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -295,6 +295,7 @@ config DRM_PANEL_OLIMEX_LCD_OLINUXINO
depends on OF
depends on I2C
depends on BACKLIGHT_CLASS_DEVICE
+ select CRC32
help
The panel is used with different sizes LCDs, from 480x272 to
1280x800, and 24 bit per pixel.
--
2.23.0.718.g5ad94255a8


2021-10-12 12:08:52

by Vegard Nossum

[permalink] [raw]
Subject: Re: [PATCH] drm/panel: olimex-lcd-olinuxino: select CRC32

Hi Thierry,

I tried sending the patch below to Stefan Mavrodiev <[email protected]>
(listed in MAINTAINERS for DRM DRIVER FOR OLIMEX LCD-OLINUXINO PANELS)
but it bounced with "No such user at that domain".

Will you take the patch and/or update the MAINTAINERS entry?

Thanks,


Vegard

On 10/12/21 1:52 PM, Vegard Nossum wrote:
> Fix the following build/link error by adding a dependency on the CRC32
> routines:
>
> ld: drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.o: in function `lcd_olinuxino_probe':
> panel-olimex-lcd-olinuxino.c:(.text+0x303): undefined reference to `crc32_le'
>
> Fixes: 17fd7a9d324fd ("drm/panel: Add support for Olimex LCD-OLinuXino panel")
> Cc: Arnd Bergmann <[email protected]>
> Signed-off-by: Vegard Nossum <[email protected]>
> ---
> drivers/gpu/drm/panel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index beb581b96ecdc..418638e6e3b0a 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -295,6 +295,7 @@ config DRM_PANEL_OLIMEX_LCD_OLINUXINO
> depends on OF
> depends on I2C
> depends on BACKLIGHT_CLASS_DEVICE
> + select CRC32
> help
> The panel is used with different sizes LCDs, from 480x272 to
> 1280x800, and 24 bit per pixel.
>