2021-10-14 13:22:49

by Mathieu Desnoyers

[permalink] [raw]
Subject: Re: [sched.h] 317419b91e: perf-sanity-tests.Parse_sched_tracepoints_fields.fail

----- On Oct 14, 2021, at 9:05 AM, Yafang Shao [email protected] wrote:
[...]
>> If it happens that this ABI break is noticed by more than an in-tree test
>> program, then
>> the kernel's ABI rules will require that this trace field size stays unchanged.
>> This brings
>> up once more the whole topic of "Tracepoints ABI" which has been discussed
>> repeatedly in
>> the past.
>>
>
> I will check if any other in-tree tools depends on TASK_COMM_LEN.

That's a start, but given this is a userspace ABI, out-of-tree userland
tools which depend of this to be fixed-size are also relevant.

Thanks,

Mathieu

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com


2021-10-14 15:36:41

by Yafang Shao

[permalink] [raw]
Subject: Re: [sched.h] 317419b91e: perf-sanity-tests.Parse_sched_tracepoints_fields.fail

On Thu, Oct 14, 2021 at 9:09 PM Mathieu Desnoyers
<[email protected]> wrote:
>
> ----- On Oct 14, 2021, at 9:05 AM, Yafang Shao [email protected] wrote:
> [...]
> >> If it happens that this ABI break is noticed by more than an in-tree test
> >> program, then
> >> the kernel's ABI rules will require that this trace field size stays unchanged.
> >> This brings
> >> up once more the whole topic of "Tracepoints ABI" which has been discussed
> >> repeatedly in
> >> the past.
> >>
> >
> > I will check if any other in-tree tools depends on TASK_COMM_LEN.
>
> That's a start, but given this is a userspace ABI, out-of-tree userland
> tools which depend of this to be fixed-size are also relevant.
>

TASK_COMM_LEN isn't defined in include/uapi/ directory, so it seems
that it isn't the uerspace ABI?


--
Thanks
Yafang