2007-01-09 01:28:59

by Kurt Garloff

[permalink] [raw]
Subject: [PATCH] scsi_scan message cosmetic error


Minor typo ...
In my first iteration of patches (that got merged), the
BLIST_ATTACH_PQ3 actually had the value 0x800000, but that
got changed later to avoid conflicts. This piece must have
been overlooked.
You could obviously do something like %x and then add the
bitflags, but that looks overkill for something that does
not tend to change.

Please merge.
(Patch applied against latest 2.6.20rc version that I tested.)

From: Kurt Garloff <[email protected]>
Subject: [SCSI SCAN] Fix logging message for PQ3 devices

The blacklist flags BLIST_ATTACH_PQ3 has value 0x1000000,
not 0x800000.

Signed-off-by: Kurt Garloff <[email protected]>

Index: linux-2.6.16-SLES10_SP1_BRANCH/drivers/scsi/scsi_scan.c
--- linux-2.6.16-SLES10_SP1_BRANCH.orig/drivers/scsi/scsi_scan.c
+++ linux-2.6.16-SLES10_SP1_BRANCH/drivers/scsi/scsi_scan.c
@@ -941,9 +941,9 @@ static int scsi_probe_and_add_lun(struct
unsigned char mod[17];

sdev_printk(KERN_INFO, sdev,
"scsi scan: consider passing scsi_mod."
- "dev_flags=%s:%s:0x240 or 0x800240\n",
+ "dev_flags=%s:%s:0x240 or 0x1000240\n",
scsi_inq_str(vend, result, 8, 16),
scsi_inq_str(mod, result, 16, 32));
Kurt Garloff <[email protected]> [Koeln, DE]
Physics:Plasma modeling <[email protected]> [TU Eindhoven, NL]
Linux: Head Architect <[email protected]> [Novell Inc]

(No filename) (1.44 kB)
(No filename) (189.00 B)
Download all attachments