2021-12-15 06:07:18

by CGEL

Subject: [PATCH iio-next] drivers/iio: remove redundant ret variable

From: Minghao Chi <[email protected]>

Return value from ads8688_prog_write() directly instead
of taking this in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/iio/adc/ti-ads8688.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/iio/adc/ti-ads8688.c b/drivers/iio/adc/ti-ads8688.c
index 79c803537dc4..2e24717d7f55 100644
--- a/drivers/iio/adc/ti-ads8688.c
+++ b/drivers/iio/adc/ti-ads8688.c
@@ -281,12 +281,10 @@ static int ads8688_write_reg_range(struct iio_dev *indio_dev,
enum ads8688_range range)
{
unsigned int tmp;
- int ret;

tmp = ADS8688_PROG_REG_RANGE_CH(chan->channel);
- ret = ads8688_prog_write(indio_dev, tmp, range);

- return ret;
+ return ads8688_prog_write(indio_dev, tmp, range);
}

static int ads8688_write_raw(struct iio_dev *indio_dev,
--
2.25.1

2021-12-16 12:26:39

by Jonathan Cameron

Subject: Re: [PATCH iio-next] drivers/iio: remove redundant ret variable

On Wed, 15 Dec 2021 06:07:10 +0000
[email protected] wrote:

> From: Minghao Chi <[email protected]>
>
> Return value from ads8688_prog_write() directly instead
> of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>

applied,

Thanks,

> ---
> drivers/iio/adc/ti-ads8688.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/ti-ads8688.c b/drivers/iio/adc/ti-ads8688.c
> index 79c803537dc4..2e24717d7f55 100644
> --- a/drivers/iio/adc/ti-ads8688.c
> +++ b/drivers/iio/adc/ti-ads8688.c
> @@ -281,12 +281,10 @@ static int ads8688_write_reg_range(struct iio_dev *indio_dev,
> enum ads8688_range range)
> {
> unsigned int tmp;
> - int ret;
>
> tmp = ADS8688_PROG_REG_RANGE_CH(chan->channel);
> - ret = ads8688_prog_write(indio_dev, tmp, range);
>
> - return ret;
> + return ads8688_prog_write(indio_dev, tmp, range);
> }
>
> static int ads8688_write_raw(struct iio_dev *indio_dev,