2022-02-09 18:52:23

by Sean Anderson

Subject: [PATCH] pinctrl: k210: Fix bias-pull-up

Using bias-pull-up would actually cause the pin to have its pull-down
enabled. Fix this.

Signed-off-by: Sean Anderson <[email protected]>
---

drivers/pinctrl/pinctrl-k210.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
index 49e32684dbb2..1ad61b32ec88 100644
--- a/drivers/pinctrl/pinctrl-k210.c
+++ b/drivers/pinctrl/pinctrl-k210.c
@@ -527,7 +527,7 @@ static int k210_pinconf_set_param(struct pinctrl_dev *pctldev,
case PIN_CONFIG_BIAS_PULL_UP:
if (!arg)
return -EINVAL;
- val |= K210_PC_PD;
+ val |= K210_PC_PU;
break;
case PIN_CONFIG_DRIVE_STRENGTH:
arg *= 1000;
--
2.34.1

2022-02-09 23:48:37

by Damien Le Moal

Subject: Re: [PATCH] pinctrl: k210: Fix bias-pull-up

On 2/10/22 03:28, Sean Anderson wrote:
> Using bias-pull-up would actually cause the pin to have its pull-down
> enabled. Fix this.
>
> Signed-off-by: Sean Anderson <[email protected]>
> ---
>
> drivers/pinctrl/pinctrl-k210.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
> index 49e32684dbb2..1ad61b32ec88 100644
> --- a/drivers/pinctrl/pinctrl-k210.c
> +++ b/drivers/pinctrl/pinctrl-k210.c
> @@ -527,7 +527,7 @@ static int k210_pinconf_set_param(struct pinctrl_dev *pctldev,
> case PIN_CONFIG_BIAS_PULL_UP:
> if (!arg)
> return -EINVAL;
> - val |= K210_PC_PD;
> + val |= K210_PC_PU;
> break;
> case PIN_CONFIG_DRIVE_STRENGTH:
> arg *= 1000;

Ooops... My bad :)

Reviewed-by: Damien Le Moal <[email protected]>

--
Damien Le Moal
Western Digital Research

2022-02-10 02:09:24

by Damien Le Moal

Subject: Re: [PATCH] pinctrl: k210: Fix bias-pull-up

On 2022/02/10 8:52, Sean Anderson wrote:
> On 2/9/22 6:34 PM, Damien Le Moal wrote:
>> On 2/10/22 03:28, Sean Anderson wrote:
>>> Using bias-pull-up would actually cause the pin to have its pull-down
>>> enabled. Fix this.
>>>
>>> Signed-off-by: Sean Anderson <[email protected]>
>>> ---
>>>
>>> drivers/pinctrl/pinctrl-k210.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
>>> index 49e32684dbb2..1ad61b32ec88 100644
>>> --- a/drivers/pinctrl/pinctrl-k210.c
>>> +++ b/drivers/pinctrl/pinctrl-k210.c
>>> @@ -527,7 +527,7 @@ static int k210_pinconf_set_param(struct pinctrl_dev *pctldev,
>>> case PIN_CONFIG_BIAS_PULL_UP:
>>> if (!arg)
>>> return -EINVAL;
>>> - val |= K210_PC_PD;
>>> + val |= K210_PC_PU;
>>> break;
>>> case PIN_CONFIG_DRIVE_STRENGTH:
>>> arg *= 1000;
>>
>> Ooops... My bad :)
>
> (This is in U-Boot as well, so it looks like it's my bad)

I copy-pasted a bug, still my bad :)

--
Damien Le Moal
Western Digital Research

2022-02-13 09:15:59

by Linus Walleij

Subject: Re: [PATCH] pinctrl: k210: Fix bias-pull-up

On Wed, Feb 9, 2022 at 7:28 PM Sean Anderson <[email protected]> wrote:

> Using bias-pull-up would actually cause the pin to have its pull-down
> enabled. Fix this.
>
> Signed-off-by: Sean Anderson <[email protected]>

Patch applied for fixes.

Yours,
Linus Walleij