2022-02-15 16:28:25

by Keoseong Park

Subject: [PATCH] scsi: ufs: Remove wlun_dev_to_hba()

Commit edc0596cc04b ("scsi: ufs: core: Stop clearing UNIT ATTENTIONS")
removed all callers of wlun_dev_to_hba(). Hence also remove the macro itself.

Signed-off-by: Keoseong Park <[email protected]>
---
drivers/scsi/ufs/ufshcd.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 41d85b69fa50..1243d73d669b 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -83,8 +83,6 @@
/* Polling time to wait for fDeviceInit */
#define FDEVICEINIT_COMPL_TIMEOUT 1500 /* millisecs */

-#define wlun_dev_to_hba(dv) shost_priv(to_scsi_device(dv)->host)
-
#define ufshcd_toggle_vreg(_dev, _vreg, _on) \
({ \
int _ret; \
--
2.17.1

2022-02-15 17:11:32

by Alim Akhtar

Subject: RE: [PATCH] scsi: ufs: Remove wlun_dev_to_hba()

>-----Original Message-----
>From: Keoseong Park [mailto:[email protected]]
>Sent: Tuesday, February 15, 2022 5:10 PM
>To: ALIM AKHTAR <[email protected]>; [email protected];
>[email protected]; [email protected]; [email protected];
>[email protected]; [email protected]; [email protected];
>[email protected]; [email protected]; linux-
>[email protected]
>Subject: [PATCH] scsi: ufs: Remove wlun_dev_to_hba()
>
>Commit edc0596cc04b ("scsi: ufs: core: Stop clearing UNIT ATTENTIONS")
>removed all callers of wlun_dev_to_hba(). Hence also remove the macro
>itself.
>
>Signed-off-by: Keoseong Park <[email protected]>
>---


Thanks!

Reviewed-by: Alim Akhtar <[email protected]>

> drivers/scsi/ufs/ufshcd.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
>41d85b69fa50..1243d73d669b 100644
>--- a/drivers/scsi/ufs/ufshcd.c
>+++ b/drivers/scsi/ufs/ufshcd.c
>@@ -83,8 +83,6 @@
> /* Polling time to wait for fDeviceInit */ #define
>FDEVICEINIT_COMPL_TIMEOUT 1500 /* millisecs */
>
>-#define wlun_dev_to_hba(dv) shost_priv(to_scsi_device(dv)->host)
>-
> #define ufshcd_toggle_vreg(_dev, _vreg, _on)
> \
> ({ \
> int _ret; \
>--
>2.17.1

2022-02-16 02:56:24

by Bart Van Assche

Subject: Re: [PATCH] scsi: ufs: Remove wlun_dev_to_hba()

On 2/15/22 03:40, Keoseong Park wrote:
> Commit edc0596cc04b ("scsi: ufs: core: Stop clearing UNIT ATTENTIONS")
> removed all callers of wlun_dev_to_hba(). Hence also remove the macro itself.

Reviewed-by: Bart Van Assche <[email protected]>

2022-02-20 06:04:01

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ufs: Remove wlun_dev_to_hba()

Keoseong,

> Commit edc0596cc04b ("scsi: ufs: core: Stop clearing UNIT ATTENTIONS")
> removed all callers of wlun_dev_to_hba(). Hence also remove the macro
> itself.

Applied to 5.18/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2022-02-28 08:14:24

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ufs: Remove wlun_dev_to_hba()

On Tue, 15 Feb 2022 20:40:02 +0900, Keoseong Park wrote:

> Commit edc0596cc04b ("scsi: ufs: core: Stop clearing UNIT ATTENTIONS")
> removed all callers of wlun_dev_to_hba(). Hence also remove the macro itself.
>
>

Applied to 5.18/scsi-queue, thanks!

[1/1] scsi: ufs: Remove wlun_dev_to_hba()
https://git.kernel.org/mkp/scsi/c/482dcaa1c91a

--
Martin K. Petersen Oracle Linux Engineering