2022-03-01 11:14:59

by Haowen Bai

Subject: [PATCH] sched/core: remove unneeded semicolon

Eliminate the following coccicheck warning:
kernel/sched/core_sched.c:210:2-3: Unneeded semicolon

Signed-off-by: Haowen Bai <[email protected]>
---
kernel/sched/core_sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/core_sched.c b/kernel/sched/core_sched.c
index c8746a9..085f188 100644
--- a/kernel/sched/core_sched.c
+++ b/kernel/sched/core_sched.c
@@ -207,7 +207,7 @@ int sched_core_share_pid(unsigned int cmd, pid_t pid, enum pid_type type,
default:
err = -EINVAL;
goto out;
- };
+ }

if (type == PIDTYPE_PID) {
__sched_core_set(task, cookie);
--
2.7.4

2022-03-02 10:29:16

by Josh Don

Subject: Re: [PATCH] sched/core: remove unneeded semicolon

On Mon, Feb 28, 2022 at 7:37 PM Haowen Bai <[email protected]> wrote:
>
> Eliminate the following coccicheck warning:
> kernel/sched/core_sched.c:210:2-3: Unneeded semicolon
>
> Signed-off-by: Haowen Bai <[email protected]>

Thanks,

Reviewed-by: Josh Don <[email protected]>

> ---
> kernel/sched/core_sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core_sched.c b/kernel/sched/core_sched.c
> index c8746a9..085f188 100644
> --- a/kernel/sched/core_sched.c
> +++ b/kernel/sched/core_sched.c
> @@ -207,7 +207,7 @@ int sched_core_share_pid(unsigned int cmd, pid_t pid, enum pid_type type,
> default:
> err = -EINVAL;
> goto out;
> - };
> + }
>
> if (type == PIDTYPE_PID) {
> __sched_core_set(task, cookie);
> --
> 2.7.4
>