2022-05-02 01:23:01

by Pali Rohár

Subject: [PATCH v2 1/2] dt-bindings: watchdog: max63xx: Add GPIO binding

GPIO is optional and used for WDI logic.

Signed-off-by: Pali Rohár <[email protected]>
---
Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
index ab9641e845db..a97aa0135ef9 100644
--- a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
+++ b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
@@ -27,6 +27,10 @@ properties:
description: This is a 1-byte memory-mapped address
maxItems: 1

+ gpios:
+ description: Optional GPIO used for controlling WDI when WDI bit is not mapped to memory
+ maxItems: 1
+
required:
- compatible
- reg
--
2.20.1

2022-05-04 05:09:49

by Rob Herring

Subject: Re: [PATCH v2 1/2] dt-bindings: watchdog: max63xx: Add GPIO binding

On Fri, Apr 29, 2022 at 03:13:48PM +0200, Pali Roh?r wrote:
> GPIO is optional and used for WDI logic.

Nowhere is WDI defined.

>
> Signed-off-by: Pali Roh?r <[email protected]>
> ---
> Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> index ab9641e845db..a97aa0135ef9 100644
> --- a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> @@ -27,6 +27,10 @@ properties:
> description: This is a 1-byte memory-mapped address
> maxItems: 1
>
> + gpios:

Usually, we want a name here. Maybe wdi-gpios, but I don't know what WDI
is nor have I read the pin name in the datasheet for inspiration.

> + description: Optional GPIO used for controlling WDI when WDI bit is not mapped to memory
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> --
> 2.20.1
>
>