2022-05-03 22:53:17

by Serge Semin

[permalink] [raw]
Subject: [PATCH v2 16/17] PCI: dwc: Introduce generic platform clocks and resets sets

Currently almost each platform driver uses its own resets and clocks
naming in order to get the corresponding descriptors. It makes the code
harder to maintain and comprehend especially seeing the DWC PCIe core main
resets and clocks signals set hasn't changed much for about at least one
major IP-core release. So in order to organize things around these signals
we suggest to create a generic interface for them in accordance with the
naming introduced in the DWC PCIe IP-core reference manual:

- DBI - data bus interface clock (on some DWC PCIe platforms it's
referred as "pclk", "pcie", "sys", "ahb", "cfg", "iface", "gio", "reg",
- MSTR - AXI-bus master interface clock (some DWC PCIe glue drivers refer
to this clock as "port", "bus", "pcie_bus",
"bus_master/master_bus/axi_m", "pcie_aclk");
- SLV - AXI-bus slave interface clock (also called as "port", "bus",
"pcie_bus", "bus_slave/slave_bus/axi_s", "pcie_aclk",
- PIPE - Core-PCS PIPE interface clock coming from external PHY (it's
normally named by the platform drivers as just "pipe")
- CORE - primary clock of the controller (none of the platform drivers
declare such a clock but in accordance with the ref. manual the devices
may have it separately specified);
- AUX - Auxiliary PMC domain clock (it is named by some platforms as
"pcie_aux" and just "aux")
- REF - Generic reference clock (it is a generic clock source, which can
be used as a signal source for multiple interfaces, some platforms call
it as "ref", "general", "pcie_phy", "pcie_phy_ref").

Application resets:
- DBI - Data-bus interface reset (it's CSR interface clock and is normally
called as "apb" though technically it's not APB but DWC PCIe-specific
apb, sys,
- MSTR -AXI-bus master reset (some platforms call it as "port", "apps",
"bus", "axi_m");
- SLV - ABI-bus slave reset (some platforms call it as "port", "apps",
"bus", "axi_s").

Core resets:
- NON_STICKY - Non-sticky CSR flags reset;
- STICKY - sticky CSR flags reset;
- PIPE - PIPE-interface (Core-PCS) logic reset (some platforms call it
just "pipe");
- CORE - controller primary reset (resets everything except PMC module,
some platforms refer to this signal as "soft", "pci");
- PHY - PCS/PHY block reset (strictly speaking it is normally connected to
the out of the external block, but the reference manual says it must be
available for the PMC working correctly, some existing platforms call it
as "pciephy", "phy", "link");
- HOT - PMC hot reset signal (also called as sleep");
- PWR - cold reset signal (can be referred as "pwr", "turnoff").

As you can see each platform uses it's own naming for basically the same
set of the signals. In the framework of this commit we suggest to add a
set of the clocks and signals identifiers and corresponding names for each
denoted entity. The platforms will be able to use them to define local
mapping tables between the generic identifiers and the available set of
the clocks and resets. The tables can be then utilized to create the
corresponding bulk-arrays, which in its turn can be passed to the
clock/reset-bulk API methods to easily get/enable/disable/put,
get/reset/assert/deassert/put all the handlers at once or, if it's
required, manipulate with the handlers individually.

Signed-off-by: Serge Semin <[email protected]>
drivers/pci/controller/dwc/pcie-designware.h | 79 ++++++++++++++++++++
1 file changed, 79 insertions(+)

diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
index 03de8f20a2cc..765d99d5bfaa 100644
--- a/drivers/pci/controller/dwc/pcie-designware.h
+++ b/drivers/pci/controller/dwc/pcie-designware.h
@@ -183,6 +183,35 @@ enum dw_pcie_device_mode {

+enum dw_pcie_clk {
+enum dw_pcie_app_rst {
+enum dw_pcie_core_rst {
struct dw_pcie_host_ops {
int (*host_init)(struct pcie_port *pp);
void (*host_deinit)(struct pcie_port *pp);
@@ -373,6 +402,56 @@ static inline void dw_pcie_dbi_ro_wr_dis(struct dw_pcie *pci)
dw_pcie_writel_dbi(pci, reg, val);

+static inline const char *dw_pcie_clk_name(enum dw_pcie_clk id)
+ static const char *names[DW_PCIE_NUM_CLKS] = {
+ [DW_PCIE_DBI_CLK] = "dbi",
+ [DW_PCIE_MSTR_CLK] = "mstr",
+ [DW_PCIE_SLV_CLK] = "slv",
+ [DW_PCIE_PIPE_CLK] = "pipe",
+ [DW_PCIE_CORE_CLK] = "core",
+ [DW_PCIE_AUX_CLK] = "aux",
+ [DW_PCIE_REF_CLK] = "ref",
+ };
+ if (id >= DW_PCIE_NUM_CLKS)
+ return NULL;
+ return names[id];
+static inline const char *dw_pcie_app_rst_name(enum dw_pcie_app_rst id)
+ static const char *names[DW_PCIE_NUM_APP_RSTS] = {
+ [DW_PCIE_DBI_RST] = "dbi",
+ [DW_PCIE_MSTR_RST] = "mstr",
+ [DW_PCIE_SLV_RST] = "slv",
+ };
+ if (id >= DW_PCIE_NUM_APP_RSTS)
+ return NULL;
+ return names[id];
+static inline const char *dw_pcie_core_rst_name(enum dw_pcie_core_rst id)
+ static const char *names[DW_PCIE_NUM_CORE_RSTS] = {
+ [DW_PCIE_NON_STICKY_RST] = "non-sticky",
+ [DW_PCIE_STICKY_RST] = "sticky",
+ [DW_PCIE_CORE_RST] = "core",
+ [DW_PCIE_PIPE_RST] = "pipe",
+ [DW_PCIE_PHY_RST] = "phy",
+ [DW_PCIE_HOT_RST] = "hot",
+ [DW_PCIE_PWR_RST] = "pwr",
+ };
+ if (id >= DW_PCIE_NUM_CORE_RSTS)
+ return NULL;
+ return names[id];
irqreturn_t dw_handle_msi_irq(struct pcie_port *pp);
int dw_pcie_setup_rc(struct pcie_port *pp);