2022-05-04 05:44:11

by Forest Crossman

[permalink] [raw]
Subject: [PATCH] tools/edid: Only include the .data section in the raw binary output

I don't know at what point this changed, but with gcc 11.2.0 and
binutils 2.38, if we don't restrict what sections are output to the raw
binary, the ".note.gnu.property" section in the object file will be
written into the first 48 bytes of the EDID, rendering it unusable.

To fix this, limit the binary output to the ".data" section.

Signed-off-by: Forest Crossman <[email protected]>
---
tools/edid/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/edid/Makefile b/tools/edid/Makefile
index 85a927dfab02..b62bfd925348 100644
--- a/tools/edid/Makefile
+++ b/tools/edid/Makefile
@@ -16,7 +16,7 @@ clean:
@cc -c $^

%.bin.nocrc: %.o
- @objcopy -Obinary $^ [email protected]
+ @objcopy -j.data -Obinary $^ [email protected]

%.crc: %.bin.nocrc
@list=$$(for i in `seq 1 127`; do head -c$$i $^ | tail -c1 \
@@ -27,10 +27,10 @@ clean:
@cc -c -DCRC="$$(cat $*.crc)" -o [email protected] $*.S

%.bin: %.p
- @objcopy -Obinary $^ [email protected]
+ @objcopy -j.data -Obinary $^ [email protected]

%.bin.ihex: %.p
- @objcopy -Oihex $^ [email protected]
+ @objcopy -j.data -Oihex $^ [email protected]
@dos2unix [email protected] 2>/dev/null

%.c: %.bin
--
2.36.0