2022-05-16 13:12:01

by Dong Chuanjian

Subject: [PATCH] scripts:modify output format

scripts:modify output format

Signed-off-by: Dong Chuanjian <[email protected]>
---
scripts/kallsyms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index 8caabddf817c..ba50993785ec 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -498,7 +498,7 @@ static void write_src(void)

output_label("kallsyms_token_index");
for (i = 0; i < 256; i++)
- printf("\t.short\t%d\n", best_idx[i]);
+ printf("\t.short\t%u\n", best_idx[i]);
printf("\n");
}

--
2.18.2

2022-05-16 14:12:17

by Randy Dunlap

Subject: Re: [PATCH] scripts:modify output format

Hi,

The change looks good to me, but there are a few other
"process" problems.

1. Was there a compiler warning that caused this patch?
If so, then tell us about it.

2. This is v2 of the patch. You should describe what changed
between v1 and v2 (below the first --- line).

Thanks.

On 5/15/22 19:04, Dong Chuanjian wrote:
> scripts:modify output format
>
> Signed-off-by: Dong Chuanjian <[email protected]>
> ---
> scripts/kallsyms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 8caabddf817c..ba50993785ec 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -498,7 +498,7 @@ static void write_src(void)
>
> output_label("kallsyms_token_index");
> for (i = 0; i < 256; i++)
> - printf("\t.short\t%d\n", best_idx[i]);
> + printf("\t.short\t%u\n", best_idx[i]);
> printf("\n");
> }
>

--
~Randy

2022-05-17 20:37:51

by Dong Chuanjian

Subject: Re: [PATCH] scripts:modify output format

The compiler does not have warnings, but the definition of the output variable is "unsigned int"，So there will be this patch.