2022-06-02 10:31:06

by Jiri Slaby

[permalink] [raw]
Subject: [PATCH 2/2] tty/vt: Makefile, add --unicode for loadkeys invocation

For a long time, we generate unicode tables using loadkeys. So fix
Makefile to use that flag too.

Signed-off-by: Jiri Slaby <[email protected]>
---
drivers/tty/vt/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/vt/Makefile b/drivers/tty/vt/Makefile
index fe30ce512819..b3dfe9d5717e 100644
--- a/drivers/tty/vt/Makefile
+++ b/drivers/tty/vt/Makefile
@@ -30,6 +30,6 @@ $(obj)/defkeymap.o: $(obj)/defkeymap.c
ifdef GENERATE_KEYMAP

$(obj)/defkeymap.c: $(obj)/%.c: $(src)/%.map
- loadkeys --mktable $< > [email protected]
+ loadkeys --mktable --unicode $< > [email protected]

endif
--
2.36.1



2022-06-06 14:51:20

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH 2/2] tty/vt: Makefile, add --unicode for loadkeys invocation

On Thu, Jun 2, 2022 at 12:30 PM Jiri Slaby <[email protected]> wrote:
>
> For a long time, we generate unicode tables using loadkeys. So fix
> Makefile to use that flag too.

generated

Does it make sense to add the Fixes tag?

Reviewed-by: Andy Shevchenko <[email protected]>

> Signed-off-by: Jiri Slaby <[email protected]>
> ---
> drivers/tty/vt/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/vt/Makefile b/drivers/tty/vt/Makefile
> index fe30ce512819..b3dfe9d5717e 100644
> --- a/drivers/tty/vt/Makefile
> +++ b/drivers/tty/vt/Makefile
> @@ -30,6 +30,6 @@ $(obj)/defkeymap.o: $(obj)/defkeymap.c
> ifdef GENERATE_KEYMAP
>
> $(obj)/defkeymap.c: $(obj)/%.c: $(src)/%.map
> - loadkeys --mktable $< > [email protected]
> + loadkeys --mktable --unicode $< > [email protected]
>
> endif
> --
> 2.36.1
>


--
With Best Regards,
Andy Shevchenko

2022-06-07 07:38:13

by Jiri Slaby

[permalink] [raw]
Subject: Re: [PATCH 2/2] tty/vt: Makefile, add --unicode for loadkeys invocation

On 06. 06. 22, 16:35, Andy Shevchenko wrote:
> On Thu, Jun 2, 2022 at 12:30 PM Jiri Slaby <[email protected]> wrote:
>>
>> For a long time, we generate unicode tables using loadkeys. So fix
>> Makefile to use that flag too.
>
> generated

We still do, but I didn't even know there is even a rule for that ;).

> Does it make sense to add the Fixes tag?

I don't think so -- I don't think anyone ran the rule in the past decade
:P. I.e. it'd be pre-git anyway.

> Reviewed-by: Andy Shevchenko <[email protected]>
>
>> Signed-off-by: Jiri Slaby <[email protected]>
>> ---
>> drivers/tty/vt/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/vt/Makefile b/drivers/tty/vt/Makefile
>> index fe30ce512819..b3dfe9d5717e 100644
>> --- a/drivers/tty/vt/Makefile
>> +++ b/drivers/tty/vt/Makefile
>> @@ -30,6 +30,6 @@ $(obj)/defkeymap.o: $(obj)/defkeymap.c
>> ifdef GENERATE_KEYMAP
>>
>> $(obj)/defkeymap.c: $(obj)/%.c: $(src)/%.map
>> - loadkeys --mktable $< > [email protected]
>> + loadkeys --mktable --unicode $< > [email protected]
>>
>> endif
>> --
>> 2.36.1
>>
>
>

thanks,
--
js
suse labs

2022-06-07 15:58:24

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH 2/2] tty/vt: Makefile, add --unicode for loadkeys invocation

On Tue, Jun 7, 2022 at 11:58 AM Andy Shevchenko
<[email protected]> wrote:
>
> On Tue, Jun 7, 2022 at 7:42 AM Jiri Slaby <[email protected]> wrote:
> > On 06. 06. 22, 16:35, Andy Shevchenko wrote:
> > > On Thu, Jun 2, 2022 at 12:30 PM Jiri Slaby <[email protected]> wrote:
> > >>
> > >> For a long time, we generate unicode tables using loadkeys. So fix
> > >> Makefile to use that flag too.
> > >
> > > generated
> >
> > We still do, but I didn't even know there is even a rule for that ;).
>
> I understand, but here is English stylistics like this. You need to
> use past ind. or present perfect ("for a long time" dictates that).

Okay, now even more explanation, present perfect should be used here.

we have generated


--
With Best Regards,
Andy Shevchenko

2022-06-07 17:26:32

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH 2/2] tty/vt: Makefile, add --unicode for loadkeys invocation

On Tue, Jun 7, 2022 at 7:42 AM Jiri Slaby <[email protected]> wrote:
> On 06. 06. 22, 16:35, Andy Shevchenko wrote:
> > On Thu, Jun 2, 2022 at 12:30 PM Jiri Slaby <[email protected]> wrote:
> >>
> >> For a long time, we generate unicode tables using loadkeys. So fix
> >> Makefile to use that flag too.
> >
> > generated
>
> We still do, but I didn't even know there is even a rule for that ;).

I understand, but here is English stylistics like this. You need to
use past ind. or present perfect ("for a long time" dictates that).

--
With Best Regards,
Andy Shevchenko