2022-06-24 18:05:43

by Prabhakar Mahadev Lad

Subject: [PATCH] irqchip/sifive-plic: Make struct irq_chip const

These should be const, so make it so.

Signed-off-by: Lad Prabhakar <[email protected]>
---
drivers/irqchip/irq-sifive-plic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
index bb87e4c3b88e..173446cc9204 100644
--- a/drivers/irqchip/irq-sifive-plic.c
+++ b/drivers/irqchip/irq-sifive-plic.c
@@ -176,7 +176,7 @@ static void plic_irq_eoi(struct irq_data *d)
}
}

-static struct irq_chip plic_chip = {
+static const struct irq_chip plic_chip = {
.name = "SiFive PLIC",
.irq_mask = plic_irq_mask,
.irq_unmask = plic_irq_unmask,
--
2.25.1

2022-08-11 17:17:53

by Palmer Dabbelt

Subject: Re: [PATCH] irqchip/sifive-plic: Make struct irq_chip const

On Fri, 24 Jun 2022 10:56:39 PDT (-0700), [email protected] wrote:
> These should be const, so make it so.
>
> Signed-off-by: Lad Prabhakar <[email protected]>
> ---
> drivers/irqchip/irq-sifive-plic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
> index bb87e4c3b88e..173446cc9204 100644
> --- a/drivers/irqchip/irq-sifive-plic.c
> +++ b/drivers/irqchip/irq-sifive-plic.c
> @@ -176,7 +176,7 @@ static void plic_irq_eoi(struct irq_data *d)
> }
> }
>
> -static struct irq_chip plic_chip = {
> +static const struct irq_chip plic_chip = {
> .name = "SiFive PLIC",
> .irq_mask = plic_irq_mask,
> .irq_unmask = plic_irq_unmask,

Reviewed-by: Palmer Dabbelt <[email protected]>
Acked-by: Palmer Dabbelt <[email protected]>

Not sure if this got picked up somewhere, but it looks fine to me.

2022-08-11 17:40:41

by Marc Zyngier

Subject: Re: [PATCH] irqchip/sifive-plic: Make struct irq_chip const

On 2022-08-11 17:53, Palmer Dabbelt wrote:
> On Fri, 24 Jun 2022 10:56:39 PDT (-0700),
> [email protected] wrote:
>> These should be const, so make it so.
>>
>> Signed-off-by: Lad Prabhakar <[email protected]>
>> ---
>> drivers/irqchip/irq-sifive-plic.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-sifive-plic.c
>> b/drivers/irqchip/irq-sifive-plic.c
>> index bb87e4c3b88e..173446cc9204 100644
>> --- a/drivers/irqchip/irq-sifive-plic.c
>> +++ b/drivers/irqchip/irq-sifive-plic.c
>> @@ -176,7 +176,7 @@ static void plic_irq_eoi(struct irq_data *d)
>> }
>> }
>>
>> -static struct irq_chip plic_chip = {
>> +static const struct irq_chip plic_chip = {
>> .name = "SiFive PLIC",
>> .irq_mask = plic_irq_mask,
>> .irq_unmask = plic_irq_unmask,
>
> Reviewed-by: Palmer Dabbelt <[email protected]>
> Acked-by: Palmer Dabbelt <[email protected]>
>
> Not sure if this got picked up somewhere, but it looks fine to me.

It probably needs respinning (the PLIC code has evolved a bit since).

M.
--
Jazz is not dead. It just smells funny...