2022-07-19 14:52:30

by Emil Renner Berthing

Subject: [PATCH v2] riscv: compat: vdso: Fix vdso_install target

When CONFIG_COMPAT=y the vdso_install target fails:

$ make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- vdso_install
INSTALL vdso.so
make[1]: *** No rule to make target 'vdso_install'. Stop.
make: *** [arch/riscv/Makefile:112: vdso_install] Error 2

The problem is that arch/riscv/kernel/compat_vdso/Makefile doesn't
have a vdso_install target, but instead calls it compat_vdso_install.

Fixes: 0715372a06ce ("riscv: compat: vdso: Add COMPAT_VDSO base code implementation")
Reported-by: Ben Hutchings <[email protected]>
Signed-off-by: Emil Renner Berthing <[email protected]>
---
v2: Add Fixes and Reported-by tags

arch/riscv/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
index 34cf8a598617..5cfbef613e34 100644
--- a/arch/riscv/Makefile
+++ b/arch/riscv/Makefile
@@ -110,7 +110,7 @@ PHONY += vdso_install
vdso_install:
$(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@
$(if $(CONFIG_COMPAT),$(Q)$(MAKE) \
- $(build)=arch/riscv/kernel/compat_vdso $@)
+ $(build)=arch/riscv/kernel/compat_vdso compat_$@)

ifeq ($(KBUILD_EXTMOD),)
ifeq ($(CONFIG_MMU),y)
--
2.37.1

2022-07-19 16:49:52

by Guo Ren

Subject: Re: [PATCH v2] riscv: compat: vdso: Fix vdso_install target

Reviewed-by: Guo Ren <[email protected]>

@Palmer Dabbelt
Please have a look at the patch which fixes up the "make vdso_install"
problem. I recommend it could be fixed in 5.19.

On Tue, Jul 19, 2022 at 9:24 PM Emil Renner Berthing
<[email protected]> wrote:
>
> When CONFIG_COMPAT=y the vdso_install target fails:
>
> $ make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- vdso_install
> INSTALL vdso.so
> make[1]: *** No rule to make target 'vdso_install'. Stop.
> make: *** [arch/riscv/Makefile:112: vdso_install] Error 2
>
> The problem is that arch/riscv/kernel/compat_vdso/Makefile doesn't
> have a vdso_install target, but instead calls it compat_vdso_install.
>
> Fixes: 0715372a06ce ("riscv: compat: vdso: Add COMPAT_VDSO base code implementation")
> Reported-by: Ben Hutchings <[email protected]>
> Signed-off-by: Emil Renner Berthing <[email protected]>
> ---
> v2: Add Fixes and Reported-by tags
>
> arch/riscv/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> index 34cf8a598617..5cfbef613e34 100644
> --- a/arch/riscv/Makefile
> +++ b/arch/riscv/Makefile
> @@ -110,7 +110,7 @@ PHONY += vdso_install
> vdso_install:
> $(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@
> $(if $(CONFIG_COMPAT),$(Q)$(MAKE) \
> - $(build)=arch/riscv/kernel/compat_vdso $@)
> + $(build)=arch/riscv/kernel/compat_vdso compat_$@)
>
> ifeq ($(KBUILD_EXTMOD),)
> ifeq ($(CONFIG_MMU),y)
> --
> 2.37.1
>


--
Best Regards
Guo Ren