2022-09-08 19:15:25

by Jingyu Wang

Subject: [PATCH] ipc: mqueue: remove unnecessary conditionals

iput() has already handled null and non-null parameter, so it is no
need to use if().

Signed-off-by: Jingyu Wang <[email protected]>
---
ipc/mqueue.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ipc/mqueue.c b/ipc/mqueue.c
index 9cf314b3f079..467a194b8a2e 100644
--- a/ipc/mqueue.c
+++ b/ipc/mqueue.c
@@ -986,8 +986,7 @@ SYSCALL_DEFINE1(mq_unlink, const char __user *, u_name)

out_unlock:
inode_unlock(d_inode(mnt->mnt_root));
- if (inode)
- iput(inode);
+ iput(inode);
mnt_drop_write(mnt);
out_name:
putname(name);

base-commit: 5957ac6635a1a12d4aa2661bbf04d3085a73372a
--
2.34.1

2022-09-08 20:35:55

by Roman Gushchin

Subject: Re: [PATCH] ipc: mqueue: remove unnecessary conditionals

On Fri, Sep 09, 2022 at 02:54:52AM +0800, Jingyu Wang wrote:
> iput() has already handled null and non-null parameter, so it is no
> need to use if().
>
> Signed-off-by: Jingyu Wang <[email protected]>

Acked-by: Roman Gushchin <[email protected]>

Thanks!