2022-09-16 20:14:11

by Horatiu Vultur

[permalink] [raw]
Subject: [PATCH] ARM: dts: lan966x: Add otp support

Add OTP (one time programmable) support.
The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.

Signed-off-by: Horatiu Vultur <[email protected]>
---
arch/arm/boot/dts/lan966x.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
index 23665a0429906..784caba369485 100644
--- a/arch/arm/boot/dts/lan966x.dtsi
+++ b/arch/arm/boot/dts/lan966x.dtsi
@@ -163,6 +163,11 @@ port7: [email protected] {
};
};

+ otp: [email protected] {
+ compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
+ reg = <0xe0021000 0x300>;
+ };
+
flx0: [email protected] {
compatible = "atmel,sama5d2-flexcom";
reg = <0xe0040000 0x100>;
--
2.33.0


2022-10-26 08:21:20

by Claudiu Beznea

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: lan966x: Add otp support

Hi, Horatiu,

I will postpone this until [1] or [2] is applied.

Thank you,
Claudiu Beznea

[1]
https://lore.kernel.org/all/[email protected]/
[2]
https://lore.kernel.org/all/[email protected]/

On 16.09.2022 22:49, Horatiu Vultur wrote:
> Add OTP (one time programmable) support.
> The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
>
> Signed-off-by: Horatiu Vultur <[email protected]>
> ---
> arch/arm/boot/dts/lan966x.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> index 23665a0429906..784caba369485 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -163,6 +163,11 @@ port7: [email protected] {
> };
> };
>
> + otp: [email protected] {
> + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
> + reg = <0xe0021000 0x300>;
> + };
> +
> flx0: [email protected] {
> compatible = "atmel,sama5d2-flexcom";
> reg = <0xe0040000 0x100>;

2022-11-23 11:09:57

by Horatiu Vultur

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: lan966x: Add otp support

The 10/26/2022 07:42, Claudiu Beznea - M18063 wrote:

Hi Claudiu,

I just want to let you know that the patch that blocked this patch
was applied and reached the linus' tree [0].
Should I resend this patch?

[0] https://elixir.bootlin.com/linux/v6.1-rc6/source/drivers/nvmem/lan9662-otpc.c#L206

> Hi, Horatiu,
>
> I will postpone this until [1] or [2] is applied.
>
> Thank you,
> Claudiu Beznea
>
> [1]
> https://lore.kernel.org/all/[email protected]/
> [2]
> https://lore.kernel.org/all/[email protected]/
>
> On 16.09.2022 22:49, Horatiu Vultur wrote:
> > Add OTP (one time programmable) support.
> > The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
> >
> > Signed-off-by: Horatiu Vultur <[email protected]>
> > ---
> > arch/arm/boot/dts/lan966x.dtsi | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> > index 23665a0429906..784caba369485 100644
> > --- a/arch/arm/boot/dts/lan966x.dtsi
> > +++ b/arch/arm/boot/dts/lan966x.dtsi
> > @@ -163,6 +163,11 @@ port7: [email protected] {
> > };
> > };
> >
> > + otp: [email protected] {
> > + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
> > + reg = <0xe0021000 0x300>;
> > + };
> > +
> > flx0: [email protected] {
> > compatible = "atmel,sama5d2-flexcom";
> > reg = <0xe0040000 0x100>;
>

--
/Horatiu

2022-11-24 15:58:15

by Claudiu Beznea

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: lan966x: Add otp support

On 23.11.2022 12:45, Horatiu Vultur - M31836 wrote:
> The 10/26/2022 07:42, Claudiu Beznea - M18063 wrote:
>
> Hi Claudiu,

Hi, Horatiu,

>
> I just want to let you know that the patch that blocked this patch
> was applied and reached the linus' tree [0].
> Should I resend this patch?

No need, I'll pick this one here!


>
> [0] https://elixir.bootlin.com/linux/v6.1-rc6/source/drivers/nvmem/lan9662-otpc.c#L206
>
>> Hi, Horatiu,
>>
>> I will postpone this until [1] or [2] is applied.
>>
>> Thank you,
>> Claudiu Beznea
>>
>> [1]
>> https://lore.kernel.org/all/[email protected]/
>> [2]
>> https://lore.kernel.org/all/[email protected]/
>>
>> On 16.09.2022 22:49, Horatiu Vultur wrote:
>>> Add OTP (one time programmable) support.
>>> The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
>>>
>>> Signed-off-by: Horatiu Vultur <[email protected]>
>>> ---
>>> arch/arm/boot/dts/lan966x.dtsi | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
>>> index 23665a0429906..784caba369485 100644
>>> --- a/arch/arm/boot/dts/lan966x.dtsi
>>> +++ b/arch/arm/boot/dts/lan966x.dtsi
>>> @@ -163,6 +163,11 @@ port7: [email protected] {
>>> };
>>> };
>>>
>>> + otp: [email protected] {
>>> + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
>>> + reg = <0xe0021000 0x300>;
>>> + };
>>> +
>>> flx0: [email protected] {
>>> compatible = "atmel,sama5d2-flexcom";
>>> reg = <0xe0040000 0x100>;
>>
>

2022-11-25 09:27:46

by Claudiu Beznea

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: lan966x: Add otp support

Hi, Horatiu,

On 16.09.2022 22:49, Horatiu Vultur wrote:
> Add OTP (one time programmable) support.
> The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.

If OTP IP is the same for both lan966x is there a reason you've added
compatibles for each SoC variants?

Thank you,
Claudiu Beznea

>
> Signed-off-by: Horatiu Vultur <[email protected]>
> ---
> arch/arm/boot/dts/lan966x.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> index 23665a0429906..784caba369485 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -163,6 +163,11 @@ port7: [email protected] {
> };
> };
>
> + otp: [email protected] {
> + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
> + reg = <0xe0021000 0x300>;
> + };
> +
> flx0: [email protected] {
> compatible = "atmel,sama5d2-flexcom";
> reg = <0xe0040000 0x100>;

2022-11-25 11:11:46

by Horatiu Vultur

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: lan966x: Add otp support

The 11/25/2022 09:23, Claudiu Beznea - M18063 wrote:
> Hi, Horatiu,

Hi Claudiu,

>
> On 16.09.2022 22:49, Horatiu Vultur wrote:
> > Add OTP (one time programmable) support.
> > The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
>
> If OTP IP is the same for both lan966x is there a reason you've added
> compatibles for each SoC variants?

When I was adding the device tree binding, Krzystof mention not to have
any wilcards in compatible string [0].

[0] https://lore.kernel.org/lkml/[email protected]/

>
> Thank you,
> Claudiu Beznea
>
> >
> > Signed-off-by: Horatiu Vultur <[email protected]>
> > ---
> > arch/arm/boot/dts/lan966x.dtsi | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> > index 23665a0429906..784caba369485 100644
> > --- a/arch/arm/boot/dts/lan966x.dtsi
> > +++ b/arch/arm/boot/dts/lan966x.dtsi
> > @@ -163,6 +163,11 @@ port7: [email protected] {
> > };
> > };
> >
> > + otp: [email protected] {
> > + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
> > + reg = <0xe0021000 0x300>;
> > + };
> > +
> > flx0: [email protected] {
> > compatible = "atmel,sama5d2-flexcom";
> > reg = <0xe0040000 0x100>;
>

--
/Horatiu

2022-11-25 11:51:31

by Claudiu Beznea

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: lan966x: Add otp support

On 25.11.2022 12:01, Horatiu Vultur - M31836 wrote:
> The 11/25/2022 09:23, Claudiu Beznea - M18063 wrote:
>> Hi, Horatiu,
>
> Hi Claudiu,
>
>>
>> On 16.09.2022 22:49, Horatiu Vultur wrote:
>>> Add OTP (one time programmable) support.
>>> The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
>>
>> If OTP IP is the same for both lan966x is there a reason you've added
>> compatibles for each SoC variants?
>
> When I was adding the device tree binding, Krzystof mention not to have
> any wilcards in compatible string [0].

I was thinking at having only one of microchip,lan9668-otpc or
microchip,lan9662-otpc whoever was first.

>
> [0] https://lore.kernel.org/lkml/[email protected]/
>
>>
>> Thank you,
>> Claudiu Beznea
>>
>>>
>>> Signed-off-by: Horatiu Vultur <[email protected]>
>>> ---
>>> arch/arm/boot/dts/lan966x.dtsi | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
>>> index 23665a0429906..784caba369485 100644
>>> --- a/arch/arm/boot/dts/lan966x.dtsi
>>> +++ b/arch/arm/boot/dts/lan966x.dtsi
>>> @@ -163,6 +163,11 @@ port7: [email protected] {
>>> };
>>> };
>>>
>>> + otp: [email protected] {
>>> + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
>>> + reg = <0xe0021000 0x300>;
>>> + };
>>> +
>>> flx0: [email protected] {
>>> compatible = "atmel,sama5d2-flexcom";
>>> reg = <0xe0040000 0x100>;
>>
>

2022-11-25 12:02:55

by Claudiu Beznea

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: lan966x: Add otp support

On 16.09.2022 22:49, Horatiu Vultur wrote:
> Add OTP (one time programmable) support.
> The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
>
> Signed-off-by: Horatiu Vultur <[email protected]>

Applied to at91-dt, thanks!

> ---
> arch/arm/boot/dts/lan966x.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> index 23665a0429906..784caba369485 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -163,6 +163,11 @@ port7: [email protected] {
> };
> };
>
> + otp: [email protected] {
> + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
> + reg = <0xe0021000 0x300>;
> + };
> +
> flx0: [email protected] {
> compatible = "atmel,sama5d2-flexcom";
> reg = <0xe0040000 0x100>;